From: Takayuki 'January June' Suwa <jjsuwa_sys3175@yahoo.co.jp>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Subject: [PATCH 2/2] xtensa: The use of CLAMPS instruction also requires TARGET_MINMAX, as well as TARGET_CLAMPS
Date: Sun, 2 Jul 2023 02:20:08 +0900 [thread overview]
Message-ID: <e9dd8d5c-14d2-cfb8-d0e1-35b14a8eb4cb@yahoo.co.jp> (raw)
In-Reply-To: <e9dd8d5c-14d2-cfb8-d0e1-35b14a8eb4cb.ref@yahoo.co.jp>
Because both smin and smax requiring TARGET_MINMAX are essential to the
RTL representation.
gcc/ChangeLog:
* config/xtensa/xtensa.cc (xtensa_match_CLAMPS_imms_p):
Simplify.
* config/xtensa/xtensa.md (*xtensa_clamps):
Add TARGET_MINMAX to the condition.
---
gcc/config/xtensa/xtensa.cc | 7 ++-----
gcc/config/xtensa/xtensa.md | 4 ++--
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/gcc/config/xtensa/xtensa.cc b/gcc/config/xtensa/xtensa.cc
index dd35e63c094..3298d53493c 100644
--- a/gcc/config/xtensa/xtensa.cc
+++ b/gcc/config/xtensa/xtensa.cc
@@ -2649,11 +2649,8 @@ xtensa_emit_add_imm (rtx dst, rtx src, HOST_WIDE_INT imm, rtx scratch,
bool
xtensa_match_CLAMPS_imms_p (rtx cst_max, rtx cst_min)
{
- int max, min;
-
- return IN_RANGE (max = exact_log2 (-INTVAL (cst_max)), 7, 22)
- && IN_RANGE (min = exact_log2 (INTVAL (cst_min) + 1), 7, 22)
- && max == min;
+ return IN_RANGE (exact_log2 (-INTVAL (cst_max)), 7, 22)
+ && (INTVAL (cst_max) + INTVAL (cst_min)) == -1;
}
diff --git a/gcc/config/xtensa/xtensa.md b/gcc/config/xtensa/xtensa.md
index b1af08eba8a..664424f1239 100644
--- a/gcc/config/xtensa/xtensa.md
+++ b/gcc/config/xtensa/xtensa.md
@@ -522,7 +522,7 @@
(smax:SI (smin:SI (match_operand:SI 1 "register_operand" "r")
(match_operand:SI 2 "const_int_operand" "i"))
(match_operand:SI 3 "const_int_operand" "i")))]
- "TARGET_CLAMPS
+ "TARGET_MINMAX && TARGET_CLAMPS
&& xtensa_match_CLAMPS_imms_p (operands[3], operands[2])"
"#"
"&& 1"
@@ -540,7 +540,7 @@
(smin:SI (smax:SI (match_operand:SI 1 "register_operand" "r")
(match_operand:SI 2 "const_int_operand" "i"))
(match_operand:SI 3 "const_int_operand" "i")))]
- "TARGET_CLAMPS
+ "TARGET_MINMAX && TARGET_CLAMPS
&& xtensa_match_CLAMPS_imms_p (operands[2], operands[3])"
{
static char result[64];
--
2.30.2
next parent reply other threads:[~2023-07-01 17:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e9dd8d5c-14d2-cfb8-d0e1-35b14a8eb4cb.ref@yahoo.co.jp>
2023-07-01 17:20 ` Takayuki 'January June' Suwa [this message]
2023-07-02 14:27 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9dd8d5c-14d2-cfb8-d0e1-35b14a8eb4cb@yahoo.co.jp \
--to=jjsuwa_sys3175@yahoo.co.jp \
--cc=gcc-patches@gcc.gnu.org \
--cc=jcmvbkbc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).