public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Martin Sebor <msebor@gmail.com>
To: "Dominique d'Humières" <dominiq@lps.ens.fr>, msebor@gcc.gnu.org
Cc: Iain Sandoe <iain@sandoe.co.uk>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] restore CFString handling in attribute format (PR 88638)
Date: Mon, 14 Jan 2019 18:55:00 -0000	[thread overview]
Message-ID: <e9e4629f-5b3f-94ed-08fa-26489b8eaf6b@gmail.com> (raw)
In-Reply-To: <D05AD8E5-C481-4908-BDC7-2B4E4B7DC7B6@lps.ens.fr>

On 1/5/19 2:41 PM, Dominique d'Humières wrote:
> Hi Martin,
> 
> The patch on top of r267591 fixes pr88638 without regression.
> 
> Note
> 
>   FAIL: c-c++-common/attributes-4.c  -std=gnu++14 (test for excess errors)
>   FAIL: c-c++-common/attributes-4.c  -std=gnu++17 (test for excess errors)
>   FAIL: c-c++-common/attributes-4.c  -std=gnu++98 (test for excess errors)
> 
> Thanks for the fix.

I just committed it.  I don't see this test fail with my Darwin
cross-compiler.  The failures I do see in attr*.c tests are these:

FAIL: gcc.dg/attr-copy-6.c (test for excess errors)
FAIL: gcc.dg/attr-ms_struct-packed1.c (test for excess errors)
FAIL: gcc.dg/attr-weakref-1-darwin.c (test for excess errors)
FAIL: gcc.dg/attr-weakref-1.c (test for excess errors)
FAIL: c-c++-common/attr-aligned-1.c  -Wc++-compat  (test for excess errors)
XPASS: c-c++-common/attr-nonstring-3.c  -Wc++-compat  pr86688 (test for 
warnings, line 409)

The attr-copy-6.c failure is due to
   error: only weak aliases are supported in this configuration

The other FAILs are all because the tests are expected to run but
can't in this configuration.

The XPASS seems to be new and present in native builds as well so
it's something to look into.

Martin

  reply	other threads:[~2019-01-14 18:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-05 21:41 Dominique d'Humières
2019-01-14 18:55 ` Martin Sebor [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-01-04 22:03 Martin Sebor
2019-01-04 22:30 ` Mike Stump
2019-01-05 10:31   ` Iain Sandoe
2019-01-05 17:39     ` Martin Sebor
2019-01-05 17:54       ` Iain Sandoe
2019-01-06 23:34         ` Martin Sebor
2019-01-07  9:26           ` Iain Sandoe
2019-01-11 22:05           ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9e4629f-5b3f-94ed-08fa-26489b8eaf6b@gmail.com \
    --to=msebor@gmail.com \
    --cc=dominiq@lps.ens.fr \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iain@sandoe.co.uk \
    --cc=msebor@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).