From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55807 invoked by alias); 14 Jan 2019 18:55:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 55748 invoked by uid 89); 14 Jan 2019 18:55:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:209.85.160.194, Hx-spam-relays-external:209.85.160.194, Hx-languages-length:1279, UD:attr-weakref-1.c X-HELO: mail-qt1-f194.google.com Received: from mail-qt1-f194.google.com (HELO mail-qt1-f194.google.com) (209.85.160.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Jan 2019 18:55:32 +0000 Received: by mail-qt1-f194.google.com with SMTP id i7so65935qtj.10; Mon, 14 Jan 2019 10:55:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fO/ugLEtrPHt/sd3BiitaNOiCTyykerfs+x2vdzuFW4=; b=XPK8BxtoIFv33WmLwRAsC6LnW/xe5tydBIIlOZBF23t4unDIsheclIxTXn0FAT5U5g 4TQxE0jgLGO7YAwSbKe7o2TNxo4ab4z5hISHDsT44LFA/3ZNLfTkAvmlbSnVJJIoK4pX eemtjGqgw0alH3lRwHAQnkDId92otiiyRUiuVIKJRzzBxD0GYE8kTJK0Q1F7pjVTtBOW r8JJYPWClZXyAQ0cvrbYAo9+KX3i7FoxBy0vUHWqBnEYuEg62yWao5EJa0oQ9onXcFQD d1+jNL5pEBqITmYUYcDP9pV9eGOfetup2oS+/G1ugGucjhVpYNfjOcTr+TditDhRW6Wh bnKg== Return-Path: Received: from [192.168.0.106] (174-16-101-177.hlrn.qwest.net. [174.16.101.177]) by smtp.gmail.com with ESMTPSA id f19sm51063925qtf.1.2019.01.14.10.55.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Jan 2019 10:55:29 -0800 (PST) Subject: Re: [PATCH] restore CFString handling in attribute format (PR 88638) To: =?UTF-8?Q?Dominique_d=27Humi=c3=a8res?= , msebor@gcc.gnu.org Cc: Iain Sandoe , gcc-patches References: From: Martin Sebor Message-ID: Date: Mon, 14 Jan 2019 18:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00794.txt.bz2 On 1/5/19 2:41 PM, Dominique d'Humières wrote: > Hi Martin, > > The patch on top of r267591 fixes pr88638 without regression. > > Note > > FAIL: c-c++-common/attributes-4.c -std=gnu++14 (test for excess errors) > FAIL: c-c++-common/attributes-4.c -std=gnu++17 (test for excess errors) > FAIL: c-c++-common/attributes-4.c -std=gnu++98 (test for excess errors) > > Thanks for the fix. I just committed it. I don't see this test fail with my Darwin cross-compiler. The failures I do see in attr*.c tests are these: FAIL: gcc.dg/attr-copy-6.c (test for excess errors) FAIL: gcc.dg/attr-ms_struct-packed1.c (test for excess errors) FAIL: gcc.dg/attr-weakref-1-darwin.c (test for excess errors) FAIL: gcc.dg/attr-weakref-1.c (test for excess errors) FAIL: c-c++-common/attr-aligned-1.c -Wc++-compat (test for excess errors) XPASS: c-c++-common/attr-nonstring-3.c -Wc++-compat pr86688 (test for warnings, line 409) The attr-copy-6.c failure is due to error: only weak aliases are supported in this configuration The other FAILs are all because the tests are expected to run but can't in this configuration. The XPASS seems to be new and present in native builds as well so it's something to look into. Martin