From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id C265C3851178 for ; Wed, 26 Oct 2022 02:47:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C265C3851178 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29Q2cM7x015512; Wed, 26 Oct 2022 02:47:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=56dzDGMjddLYS0crSL2Qy+GPQIk6pzkDpsVaIxojfac=; b=CjJELy2MUitx0pSYw7YgyOkWqVcxlvdfnyip8whBU8B8l3mEViOF8VyC+AMX1gWLoPFI PZURbD6bQ96VUMqfkfUeTjOV97oo3rdoBqAbPppZwHwQ/SNvuqofMYCVCXPLeWDa78F/ RJK1RaMBMHfF22Wrrem/mYtuW0J1KDsyNQY/kISfNXZSnDDE6Cl2e+yzhKW4zwA90+Z8 ogp4krdYNxl/afepwcc+c1++nCEdjJ6ES8c5ZgwXvKEN8QkxHbxgwMS6hmu6saDXfgI1 I5ESPnapuoymRmqB2+FVjefoxblmVkugCNNKVJbtBUTdtwH5+V7cInj4X0Uo2ucAXTy9 IA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ked6rpk6r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Oct 2022 02:47:22 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 29Q27qa8003481; Wed, 26 Oct 2022 02:47:22 GMT Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ked6rpk5x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Oct 2022 02:47:21 +0000 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 29Q2aScD011094; Wed, 26 Oct 2022 02:47:19 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma04fra.de.ibm.com with ESMTP id 3kc859ndx2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Oct 2022 02:47:19 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 29Q2lH6266847222 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Oct 2022 02:47:17 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 311DD11C050; Wed, 26 Oct 2022 02:47:17 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6F7EE11C052; Wed, 26 Oct 2022 02:47:15 +0000 (GMT) Received: from [9.197.236.86] (unknown [9.197.236.86]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 26 Oct 2022 02:47:15 +0000 (GMT) Message-ID: Date: Wed, 26 Oct 2022 10:47:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] testsuite: Fix failure in test pr105586.c [PR107171] Content-Language: en-US To: Surya Kumari Jangala Cc: Peter Bergner , gcc-patches@gcc.gnu.org, Segher Boessenkool , David Edelsohn References: <8723e38f-f7ee-aac7-7b8d-3dce61038a9f@linux.vnet.ibm.com> From: "Kewen.Lin" In-Reply-To: <8723e38f-f7ee-aac7-7b8d-3dce61038a9f@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: zBfV4mxxz6JykK1S8nJVBisTK3RPRN-2 X-Proofpoint-ORIG-GUID: YuSmjDYCEBKKEqzJAQuIhF1pneXes4QW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-25_15,2022-10-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210260010 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Surya, on 2022/10/14 01:02, Surya Kumari Jangala via Gcc-patches wrote: > testsuite: Fix failure in test pr105586.c [PR107171] > > The test pr105586.c fails on a big endian system when run in 32bit > mode. The failure occurs as the test case does not guard against > unsupported __int128. > I thought this is taken as an obvious fix and it didn't ask for a review/approval, but I just noticed it's not committed yet, so I assumed maybe you meant to ask for an approval? Then this patch is OK, it's even obvious, thanks! BR, Kewen > 2022-10-13 Surya Kumari Jangala > > gcc/testsuite/ > PR testsuite/107171 > * gcc.target/powerpc/pr105586.c: Guard against unsupported > __int128. > > > diff --git a/gcc/testsuite/gcc.target/powerpc/pr105586.c b/gcc/testsuite/gcc.target/powerpc/pr105586.c > index bd397f5..3f88a09 100644 > --- a/gcc/testsuite/gcc.target/powerpc/pr105586.c > +++ b/gcc/testsuite/gcc.target/powerpc/pr105586.c > @@ -1,4 +1,5 @@ > /* { dg-options "-mdejagnu-tune=power4 -O2 -fcompare-debug -fno-if-conversion -fno-guess-branch-probability" } */ > +/* { dg-require-effective-target int128 } */ > > extern int bar(int i);