From: Robin Dapp <rdapp@linux.ibm.com>
To: Jeff Law <jeffreyalaw@gmail.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] testsuite: Add vect_floatint_cvt to gcc.dg/vect/pr56541.c
Date: Wed, 9 Jun 2021 14:39:34 +0200 [thread overview]
Message-ID: <e9f94b32-8a7b-b2af-7fa1-704ac1de5a12@linux.ibm.com> (raw)
In-Reply-To: <b85b2d85-5d2f-6a32-006d-91b1120064d6@gmail.com>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.dg/vect/pr56541.c: Add vect_floatint_cvt.
>
> OK. I'd tend to use XFAIL for a compiler bug that we haven't fixed. In
> this case the target doesn't support what the test is trying to do. So
> skipping the test in one manner or another seems better.
Just realized I seem to have have committed the only option that is
definitely wrong... Probably got confused because of switching back and
forth between the two correct alternatives too often. Therefore I will
be committing
diff --git a/gcc/testsuite/gcc.dg/vect/pr56541.c
b/gcc/testsuite/gcc.dg/vect/pr56541.c
index e1cee6d0b0e..fa86142716b 100644
--- a/gcc/testsuite/gcc.dg/vect/pr56541.c
+++ b/gcc/testsuite/gcc.dg/vect/pr56541.c
@@ -24,4 +24,4 @@ void foo()
}
}
-/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" {
target { ! vect_floatint_cvt } xfail { ! vect_cond_mixed } } } } */
+/* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" {
target { vect_floatint_cvt } xfail { ! vect_cond_mixed } } } } */
as obvious (the target should support vect_floatint_cvt for the test).
Regards
Robin
--
gcc/testsuite/ChangeLog:
* gcc.dg/vect/pr56541.c: Do not skip vect_cond_mixed.
prev parent reply other threads:[~2021-06-09 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 14:31 Robin Dapp
2021-05-05 17:05 ` Jeff Law
2021-06-09 12:39 ` Robin Dapp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9f94b32-8a7b-b2af-7fa1-704ac1de5a12@linux.ibm.com \
--to=rdapp@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).