From: Tom de Vries <Tom_deVries@mentor.com>
To: Cesar Philippidis <cesar@codesourcery.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH,PTX] Add support for CUDA 9
Date: Wed, 20 Dec 2017 23:15:00 -0000 [thread overview]
Message-ID: <ea083a84-bc0b-4673-e326-d154fb878fe4@mentor.com> (raw)
In-Reply-To: <a0293edb-15b0-c04d-5b88-df727b31b850@codesourcery.com>
On 12/20/2017 11:59 PM, Cesar Philippidis wrote:
> On 12/19/2017 04:39 PM, Tom de Vries wrote:
>> On 12/20/2017 12:25 AM, Cesar Philippidis wrote:
>>> In CUDA 9, Nvidia removed support for treating the labels of functions
>>> as generic address spaces as part of their PTX 6.0 changes. More
>>> specifically,
>>> <http://docs.nvidia.com/cuda/parallel-thread-execution/index.html#changes-in-ptx-isa-version-6-0>:
>>>
>>>
>>> Â Â Support for taking address of labels, using labels in initializers
>>> Â Â which was unimplemented has been removed from the spec.
>>>
>>> Despite targeting PTX 3.0, the ptxas assembler shipped with CUDA 9 no
>>> longer support that legacy functionality. Consequently, this prevented
>>> newlib from building. This patch fixes that problem by not using a
>>> generic address space when initializing variables using a label address.
>>>
>>
>> What is the effect for pre-9.0 cudas?
>
> No change in the libgomp execution test suite as an accelerator.
>
>>> Is this OK for trunk?
>>>
>>
>> How did you test this?
>
> Just libgomp as an accelerator for now. I'm trying to get standalone
> nvptx working right now.
Indeed, you should test that as well, both with 9.0 and pre 9.0 cuda.
> Which testsuites do you usually run? I only see
> the test results for check-gcc-c in your nightly build bot.
>
The gcc test suite should be enough.
Thanks,
- Tom
next prev parent reply other threads:[~2017-12-20 23:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 23:25 Cesar Philippidis
2017-12-20 0:40 ` Tom de Vries
2017-12-20 22:59 ` Cesar Philippidis
2017-12-20 23:15 ` Tom de Vries [this message]
2017-12-21 17:19 ` Cesar Philippidis
2017-12-27 9:16 ` Tom de Vries
2018-01-17 17:31 ` Cesar Philippidis
2018-01-17 23:23 ` Tom de Vries
2018-01-19 4:27 ` Cesar Philippidis
2018-01-19 8:46 ` Tom de Vries
2018-02-27 14:08 ` Thomas Schwinge
2018-02-27 14:12 ` Richard Biener
2018-03-02 8:45 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea083a84-bc0b-4673-e326-d154fb878fe4@mentor.com \
--to=tom_devries@mentor.com \
--cc=cesar@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).