From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by sourceware.org (Postfix) with ESMTPS id C62C2388456D for ; Wed, 19 Jun 2024 14:33:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C62C2388456D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C62C2388456D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::72d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718807585; cv=none; b=inSwHwOsrjVCT7foFnJa+XsDb95h7qsXn3kHEPBNlffU1a16ZlzDS74maahHChTCPkHdAcDnKVZSdymsEW217BkIpgV8157Qeit++OXLfdI4j5pZbpe/nK2cltun1FQrRuz9gbQ2oURvTpkB4K5xzdnCbHa2SoZFPGvLarr5zM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718807585; c=relaxed/simple; bh=oX8YyKo6rn5UnJoFNfxI5dujBeW7K2wSOu+lcVE/MsY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EqZfwc65vfb2FpwTcT6NUtpwER18VySs2dXKt8h3NI8RZN5vrqFOsX32LUtCNHJyvKZZ7O+K8450bVkqHke1OJC4r4D6ZmSt+RYT+1Gl1u4UTMrgw9kDAFQF23DrjLbbv6I0JBqvpnlolf3RghhtRLWT0jI+CelmuomEI3P1Iz4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-797f1287aa3so474675685a.2 for ; Wed, 19 Jun 2024 07:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718807583; x=1719412383; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=En/CKuSV6CjX6KzufnzV1a35wrrN4CinIlvB26TjvDU=; b=jpmmqHBaUUnzSkIkUF7A3YFBNJdHk04GV+0l1ugt8/ldHd8rjXtftQz2UBTAn+r6sk 1267TmYQjL2BAZ25NiTwHdGGkhrZH1J6seL23MoTFHctVAA4/VghrK65+4NXo7czVH16 SmYOmulGIrlYUvbuOHq5GZvK8azs5kCYmICmnRO2OQThDGo5MH34CkjeNatYlTcOia35 aGRDGSZLQnTLFOe9SBQ14G4j4w2P2QVGU0yF1h7kVtWNkD5CEAw3UWx3q67Mlnro3tgD g8cr+nSGOgulM84RD745EN9BKEHPspoFdgS4vu4nWTPBpAWWDJeUPd5jjUUAfFm/Ob51 o54w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718807583; x=1719412383; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=En/CKuSV6CjX6KzufnzV1a35wrrN4CinIlvB26TjvDU=; b=sDEAKVXy5VshdykZij3+6KK8pugRBzzJNFnrSXOgDwnzY8qhK3NtI/nhUi19/C2DFh rHSf4f5+XFL2H4gMxQrIQANZkTnNmHQ3O4EPQZROF6YBSkWvOOwIY5s0SB76pEJTvRqk dAWyu1WEkep+YAAH/EjjBVp5c+rFZARmxi+9DnahZQtTRi24nF1r95dOOHcGuSMqOEBj IAx1yuoDsbWtaaCYfS49QvFohSPvvqwbNsckA/iVobwZxRvI+gyr99dwgTg42OZ3cGz8 /r/WOLelhrAp1V+kKtckdFpJ9I4SaRZ8xABfZtugYsmHvF8jWAxf/ZUdVOc9COjMaQgx VjSg== X-Forwarded-Encrypted: i=1; AJvYcCV7vH+lqdFw61ZWNGAaBb+cPxOAFGYsgF4V8DCHHe+VbGM6zNNV2mrmdb7czq+bIV3jq6r8hBF8aWXO7k8yC0K51qZ3MyIejw== X-Gm-Message-State: AOJu0YwFosLXdDBFAeXQSrH1Zb/0wFEBP8ZfjHXR+iJ7h6bB0K1Eye9/ kcmpe90jXFi2dRuRRAd2sPr0ggb+khvvuAGUXfeuowlDthfrRune X-Google-Smtp-Source: AGHT+IE0G4IJrDGwmtXvvwyNi7yx1NlRMEVpdeKznq3KTTVub5k/kDYVb7h8hI3JX4dqU99F9bePyw== X-Received: by 2002:a0c:e191:0:b0:6b5:a20:3b4d with SMTP id 6a1803df08f44-6b50a203ba2mr11472866d6.5.1718807582961; Wed, 19 Jun 2024 07:33:02 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b2a5eb4a83sm78142186d6.94.2024.06.19.07.33.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jun 2024 07:33:02 -0700 (PDT) Message-ID: Date: Wed, 19 Jun 2024 08:33:00 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v2] RISC-V: Remove float vector eqne pattern Content-Language: en-US To: "demin.han" , gcc-patches@gcc.gnu.org Cc: juzhe.zhong@rivai.ai, kito.cheng@gmail.com, pan2.li@intel.com, rdapp.gcc@gmail.com References: <20240619123042.1972514-1-demin.han@starfivetech.com> From: Jeff Law In-Reply-To: <20240619123042.1972514-1-demin.han@starfivetech.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/19/24 6:30 AM, demin.han wrote: > We can unify eqne and other comparison operations. > > Tested on RV32 and RV64 > > gcc/ChangeLog: > > * config/riscv/riscv-vector-builtins-bases.cc: Remove eqne cond > * config/riscv/vector.md (@pred_eqne_scalar): Remove patterns > (*pred_eqne_scalar_merge_tie_mask): Ditto > (*pred_eqne_scalar): Ditto > (*pred_eqne_scalar_narrow): Ditto > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/base/float-point-cmp-eqne.c: New test. > > Signed-off-by: demin.han > --- > > v2 changes: > 1. add test > > Only intrinsics utilize those removed vf patterns. > Auto vectorization use vv format now. > The NaN will optimized out before expand in autovec as I tested. > > .../riscv/riscv-vector-builtins-bases.cc | 4 - > gcc/config/riscv/vector.md | 86 ------------------- > .../riscv/rvv/base/float-point-cmp-eqne.c | 54 ++++++++++++ > 3 files changed, 54 insertions(+), 90 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/riscv/rvv/base/float-point-cmp-eqne.c > > diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc > index b6f6e4ff37e..d414721ede8 100644 > --- a/gcc/config/riscv/riscv-vector-builtins-bases.cc > +++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc > @@ -1420,10 +1420,6 @@ public: > switch (e.op_info->op) > { > case OP_TYPE_vf: { > - if (CODE == EQ || CODE == NE) > - return e.use_compare_insn (CODE, code_for_pred_eqne_scalar ( > - e.vector_mode ())); > - else > return e.use_compare_insn (CODE, code_for_pred_cmp_scalar ( > e.vector_mode ())); Formatting nit. You removed the IF-THEN-ELSE construct, leaving just the ELSE's body. You need to reindent that body, both lines of which would move left by two spaces. I'll fix and push it momentarily. jeff