From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 63D593857006 for ; Tue, 18 Jul 2023 10:03:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 63D593857006 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-992dcae74e0so759056666b.3 for ; Tue, 18 Jul 2023 03:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689674585; x=1692266585; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Oq/fWqAoseVvXssRuWG/E4JC75kgLkPMreuQoWCDlC8=; b=a9QyazwAn1WWi/uGKOC6YJjI8+MQsIP7GDVi+/DHPuubJ1xYCvH4mp8LyF1pQNLhgZ ceyEeNplSFJ8ByP9YlmkIT6HbdIAEXQD/pSFq/AUpH0/qswlYfgDTvFsRs89ekedJuYK sUFffCAymcQY1sgaaZ7O2kt2GOoOYZ3sp4d435Ta46P2Qd10tqfO0SoDOioPcvdFBqP1 XOcjW/s6rbdoc2vSSNPT3K/IKce17jLSp51eg8Ca64csXZBUmN1nnB/rdyqk6OFoEpvu F0e7gAYv05oMzPq8kG1VqsaOQSDMJcRnN3js/uubqEnqnQrE8SoxbFPAyQaoLbZnz1Bk OhDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689674585; x=1692266585; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Oq/fWqAoseVvXssRuWG/E4JC75kgLkPMreuQoWCDlC8=; b=E89BpEzOFxLrZATLrc4h7vw2TtPA+0uIW6V90WisPgDq9AsyMZWlYxVJ5EU0dVdgPR Jh6QZ0PkJ1QbLRHcIkqPAhl0LnSrZKQud0/SR9JJFBqU84L3cNVnkX6tNcinQbe6uJUp i462MIeueU9JEd+6TBNkrbELcD4dNsrBnixgDN4zwl+5Y3zoAz9qLo7cO+4KjPgG92sr gsOidhPWxP11TqejxPffg97qUxSJ05gWqmwRAS0Eo0k9kpyI72SjUVarztEkGbgi5EoM CxcdcOeRdw1y8T8Y2dVivjmNoJcdyG+MGt/juZrSpjVQYkkgswucQT+ImpujAwhvJAoE 6exQ== X-Gm-Message-State: ABy/qLbOrajw+70GNdGgvSSgBJovxw3newIDzFtiEMZG0urWEUMO0o2u cuvFU2FPaLQiqbkADaQF55s= X-Google-Smtp-Source: APBJJlHchsk3aU43kRqOIylEt1ctjFwjTOnhafIEgke4DrBvfSYuj6KDmmyY29ROEu1WsmmQackecw== X-Received: by 2002:a17:906:292:b0:994:47a0:3d24 with SMTP id 18-20020a170906029200b0099447a03d24mr1495011ejf.30.1689674585448; Tue, 18 Jul 2023 03:03:05 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id lw17-20020a170906bcd100b00993017b64a8sm793540ejb.224.2023.07.18.03.03.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jul 2023 03:03:04 -0700 (PDT) Message-ID: Date: Tue, 18 Jul 2023 12:03:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: rdapp.gcc@gmail.com, "juzhe.zhong" , "kito.cheng" , palmer , jeffreyalaw Subject: Re: [PATCH] RISC-V: Fix testcase failed when default -mcmodel=medany Content-Language: en-US To: Lehua Ding , gcc-patches References: <20230718074249.236825-1-lehua.ding@rivai.ai> <1009A8E07E6305DA+tencent_31597DB05C4FCE002267D617ED8672D6DB0A@qq.com> From: Robin Dapp In-Reply-To: <1009A8E07E6305DA+tencent_31597DB05C4FCE002267D617ED8672D6DB0A@qq.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Lehua, > I think the purpose of this testcase is to check whether the modifications to > the stack frame are as expected, so it is necessary to specify exactly whether > three or four registers are saved. But I think its need to add another testcase > which use another option -mcmodel=medany for coverage. In general I'm fine with this small change of course, I just wonder if the test case is not brittle anyway. From what I can tell the respective change is independent of the actual number of registers so maybe it's enough to not compare the fully body but just make sure the addis are not present? That way, the test could also work for -march=rv64 (which saves one register less anyway regardless of mcmodel - but the change still helps) or maybe even with instruction scheduling. Would you mind checking this still? Thanks. If it turns out not to be possible, let's stick with the medany fix for now and add a TODO. Regards Robin