From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by sourceware.org (Postfix) with ESMTPS id A0ADA3848414 for ; Mon, 16 Aug 2021 11:51:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A0ADA3848414 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17GBlicb025817 for ; Mon, 16 Aug 2021 13:51:48 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3af28xmn94-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 16 Aug 2021 13:51:48 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 851E510002A for ; Mon, 16 Aug 2021 13:51:47 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 5818923146C for ; Mon, 16 Aug 2021 13:51:47 +0200 (CEST) Received: from [10.211.9.129] (10.75.127.51) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 16 Aug 2021 13:51:47 +0200 Subject: Re: [PATCH] arm: Fix multilib mapping for CDE extensions [PR100856] To: gcc Patches References: <71064e87-e296-4bfd-e934-9b582e2ed3de@foss.st.com> From: Christophe LYON Message-ID: Date: Mon, 16 Aug 2021 13:51:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-16_04:2021-08-16, 2021-08-16 signatures=0 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Aug 2021 11:52:00 -0000 ping? On 11/08/2021 16:06, Christophe Lyon wrote: > ping? > https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575310.html > > > > On Wed, Aug 4, 2021 at 11:13 AM Christophe Lyon via Gcc-patches > > wrote: > > ping? > > On Thu, 15 Jul 2021 at 15:07, Christophe LYON via Gcc-patches > > wrote: > > > > This is a followup to Srinath's recent patch: the newly added > test is > > failing e.g. on arm-linux-gnueabihf without R/M profile multilibs. > > > > It is also failing on arm-eabi with R/M profile multilibs if the > > execution engine does not support v8.1-M instructions. > > > > The patch avoids this by adding check_effective_target_FUNC_multilib > > in target-supports.exp which effectively checks whether the target > > supports linking and execution, like what is already done for other > > ARM effective targets.  pr100856.c is updated to use it instead of > > arm_v8_1m_main_cde_mve_ok (which makes the testcase a bit of a > > duplicate with check_effective_target_FUNC_multilib). > > > > In addition, I noticed that requiring MVE does not seem > necessary and > > this enables the test to pass even when targeting a CPU without MVE: > > since the test does not involve actual CDE instructions, it can pass > > on other architecture versions.  For instance, when requiring > MVE, we > > have to use cortex-m55 under QEMU for the test to pass because the > > memset() that comes from v8.1-m.main+mve multilib uses LOB > > instructions (DLS) (memset is used during startup). Keeping > > arm_v8_1m_main_cde_mve_ok would mean we would enable the test > provided > > we have the right multilibs, causing a runtime error if the > simulator > > does not support LOB instructions (e.g. when targeting cortex-m7). > > > > I do not update sourcebuild.texi since the CDE effective targets are > > already collectively documented. > > > > Finally, the patch fixes two typos in comments. > > > > 2021-07-15  Christophe Lyon  > > > > >          PR target/100856 > >          gcc/ > >          * config/arm/arm.opt: Fix typo. > >          * config/arm/t-rmprofile: Fix typo. > > > >          gcc/testsuite/ > >          * gcc.target/arm/acle/pr100856.c: Use > arm_v8m_main_cde_multilib > >          and arm_v8m_main_cde. > >          * lib/target-supports.exp: Add > > check_effective_target_FUNC_multilib for ARM CDE. > > > > >