From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id DB30C381DCC3 for ; Tue, 22 Jun 2021 18:40:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DB30C381DCC3 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-465-mOJ0iGZBPA62b-xNeM8o_g-1; Tue, 22 Jun 2021 14:40:57 -0400 X-MC-Unique: mOJ0iGZBPA62b-xNeM8o_g-1 Received: by mail-qk1-f199.google.com with SMTP id o189-20020a378cc60000b02903b2ccd94ea1so2651054qkd.19 for ; Tue, 22 Jun 2021 11:40:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hqo6oNZmK6njbKz/a1urT3cB2eaVICJK96mt8Xu4R3A=; b=GcaygXDXfyYqqxad10dk5i/OnZuXlAuVqOvwblDT+3/psIwEgnEN7zbaZ9kgqboNcT zgIxHsi1hgLWLliY6GNvm0wCgh/8a7TvOINiN7rNtfInPMSTc6FxI6pSnDtxONZVw6nS ZGbtjmh9wGyHRIn3pzaoqISnwQ6Eg0exybqOyQFkX0JxsgdPxEd33DkW3lGUGi4st35n 7OLZKv//196dKhd2kwqEBb9Zjskztm0Pv6wf4blqIDiSgCgd3yfwffWgQtRayQRFzPwg qat8vYOyoHy7RE1ehQ2fZA53xE8RKJ04sp3lAiaggtzc2B41MOoOt+43Wl5+54hdKRp2 Su5w== X-Gm-Message-State: AOAM532uNM3jofnL/54SK9KzdEFUoqb69Yw0oXhwJTTttMUWvSsON12T TMSKrwRfNLWAwKk0IKftWr+BZobfkmM9IYhALJ2Oj7X+0qUGJwUWGJPZsGRK5i0gdIwwBK6YKI/ YYyaGekpWsPCxXI+Hdu6f9UVqe1BXmBHE6UZkKUp9J3/kAQuWhYDtR5Y+s98y/gYQ2A== X-Received: by 2002:a37:9f47:: with SMTP id i68mr5876895qke.266.1624387256786; Tue, 22 Jun 2021 11:40:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSJGKUgJoHBSiVTFxg7GIfvap2Vaekzps51llbLI7bYZE0ZkdowpHZqnBeaBWX9zARSmVklQ== X-Received: by 2002:a37:9f47:: with SMTP id i68mr5876867qke.266.1624387256459; Tue, 22 Jun 2021 11:40:56 -0700 (PDT) Received: from [192.168.1.148] (130-44-159-43.s11817.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id h2sm2216200qtj.41.2021.06.22.11.40.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Jun 2021 11:40:55 -0700 (PDT) Subject: Re: [RFC][PATCH] contrib: add git-commit-mklog wrapper To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , Tobias Burnus , Martin Sebor Cc: Jakub Jelinek , gcc Mailing List , Jonathan Wakely , gcc-patches References: <58b63929-01f5-038c-931c-9ff8349d9f95@gmail.com> <71b4a023-efb2-6c6a-9ced-93cce7c96540@gmail.com> <3c66efd4-eb5e-f2bb-6138-4126b5909c9c@codesourcery.com> <80fee54a-c007-a62b-20e2-41bb54a2bd00@suse.cz> <870491ea-a0bf-3ac3-14d3-1aec951a356c@codesourcery.com> <0e604906-df5a-455b-9a26-4c5519e261b6@suse.cz> <26c6e47d-38e3-83c2-36ce-1786510e00ed@codesourcery.com> From: Jason Merrill Message-ID: Date: Tue, 22 Jun 2021 14:40:54 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2021 18:41:00 -0000 On 6/22/21 3:30 AM, Martin Liška wrote: > Hello. > > There's a patch candidate that comes up with a wrapper for 'git > commit-mklog' alias. > Using my patch, one can do: > > $ git commit-mklog -a -b 12345,4444 > > Thoughts? Looks good to me. > Can one do that without the wrapper script and passing data through env. > variable? The hook seems like the way to adjust the commit message, and we can't affect its command line arguments, so we're left with environment variables or a file somewhere for communicating to it. Jason