On 8/10/21 2:29 AM, Tobias Burnus wrote: > > [snip] > > To conclude: I like the code changes (LGTM); the > '__float128' -> 'TFmode' comment change also matches the code. > > However, I think both longer comments need to be updated. OK. I used your wording verbatim for the first one. For the second one, I'm still pretty confused as I think it is at least theoretically possible on PowerPC to have a target with 64-bit long double (AIX?) that also supports the __ibm128 format, and it would be wrong to assume that *any* 128-bit mode that's not long double is IEEE. So I decided the best thing is just to replace the FIXME with a pointer to the issue I opened yesterday https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101835 and folks who actually understand this stuff can add some more discussion there. Here's a new version of the patch with changes to the two comments only. OK to commit this one? -Sandra