From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 12663385841C for ; Mon, 30 Aug 2021 08:13:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 12663385841C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0216E20071; Mon, 30 Aug 2021 08:13:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1630311202; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rMWhzMuVief3taK1Nzyy9qhPC12NkSyXh9CofYJ/UlI=; b=l7CAmN/IUYl8jeueYwLNRdNmbzfePklbJxIBlOjhWudqJJmKZb9ZV0OqVNWrrarPVavI1Q U8+2PP5gpG2aUWPt/AhuR4RPmCqsiuDoWDsnrbI/EujKN5REL41rEUEIfbG9lR7NkgpjSu txfNfRDev/0p1NxbBXxUkH2oiMFwPzs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1630311202; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rMWhzMuVief3taK1Nzyy9qhPC12NkSyXh9CofYJ/UlI=; b=E/L61mp9w7nFis4gfRf4eOBvwvudiX35KQmoChFV0G8bJ4YCHRHaOrUySLSI9l/1SY8vJx qHHsmMSyjP3XNHBg== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id D4C3D13706; Mon, 30 Aug 2021 08:13:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id l5GkMiGTLGHvIQAAGKfGzw (envelope-from ); Mon, 30 Aug 2021 08:13:21 +0000 Message-ID: Date: Mon, 30 Aug 2021 10:13:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0.1 Subject: Re: [PATCH][pushed] Add -fprofile-reproducible=parallel-runs to STAGEfeedback_CFLAGS to Makefile.tpl. Content-Language: en-US To: Gleb Fotengauer-Malinovskiy Cc: gcc-patches@gcc.gnu.org References: From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2021 08:13:33 -0000 On 8/27/21 19:45, Gleb Fotengauer-Malinovskiy wrote: > Hi, > > On Thu, Mar 11, 2021 at 04:19:51PM +0100, Martin Liška wrote: >> Pushed as obvious, the original change was done >> in g:e05a117dc4b98f3ac60851608f532ba7cee7343a. >> >> Martin >> >> ChangeLog: >> >> * Makefile.tpl: The change was done Makefile.in which >> is generated file. >> --- >> Makefile.tpl | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Makefile.tpl b/Makefile.tpl >> index 3b88f351d5b..6e0337fb48f 100644 >> --- a/Makefile.tpl >> +++ b/Makefile.tpl >> @@ -488,7 +488,7 @@ STAGEprofile_TFLAGS = $(STAGE2_TFLAGS) >> STAGEtrain_CFLAGS = $(filter-out -fchecking=1,$(STAGE3_CFLAGS)) >> STAGEtrain_TFLAGS = $(filter-out -fchecking=1,$(STAGE3_TFLAGS)) >> >> -STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use >> +STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use -fprofile-reproducible=parallel-runs > > Did you mean to add -fprofile-reproducible flag to STAGEprofile_CFLAGS > instead? No. > I suppose this flag doesn't mean anything without > -fprofile-generate, which is passed through STAGEprofile_CFLAGS. The flag -fprofile-reproducible is used when we use a collected profile, so it works *only* with -fprofile-use flag. Thanks for heads up! Cheers, Martin > > Thanks, >