From: Jeff Law <jeffreyalaw@gmail.com>
To: Martin Sebor <msebor@gmail.com>,
Richard Biener <richard.guenther@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH v3] detect out-of-bounds stores by atomic functions [PR102453]
Date: Sun, 24 Oct 2021 20:21:39 -0600 [thread overview]
Message-ID: <eb109c6e-4e6a-add2-021a-216f3cf5d0e6@gmail.com> (raw)
In-Reply-To: <f3f708fe-7c91-7ac6-84d8-f9818e537352@gmail.com>
On 10/24/2021 5:40 PM, Martin Sebor via Gcc-patches wrote:
> Attached is a revised patch for just the access warning pass
> to diagnose out-of-bounds stores by atomic functions, with
> no attr-fnspec changes.
>
> Is this okay for trunk?
>
> Martin
>
> PS Just to clarify the effect of the original patch in case
> it wasn't: it didn't enable optimizations of atomic built-ins.
> It just made it possible, by first calling the new
> atomic_builtin_fnspec() to get the fnspec, and then by actually
> doing something with it. The original patch did not modify
> builtin_fnspec() to call the new atomic_builtin_fnspec(). But
> since you seem to have reservations about exposing the attribute
> in any form I have withdrawn the original patch and replaced it
> with the more limited one.
>
>
I'm letting Richi take the lead here. But I did notice a tiny nit:
> +
> + /* Tyhe size in bytes of the access by the function, and the number
s/Tyhe/The/
next prev parent reply other threads:[~2021-10-25 2:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 21:25 [PATCH] " Martin Sebor
2021-10-12 6:52 ` Richard Biener
2021-10-12 19:44 ` [PATCH v2] " Martin Sebor
2021-10-13 8:15 ` Richard Biener
2021-10-24 23:40 ` [PATCH v3] " Martin Sebor
2021-10-25 2:21 ` Jeff Law [this message]
2021-10-26 8:23 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb109c6e-4e6a-add2-021a-216f3cf5d0e6@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=msebor@gmail.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).