From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id CD33E3858D3C for ; Tue, 10 May 2022 22:46:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD33E3858D3C Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24AMHn7O007821; Tue, 10 May 2022 22:46:11 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g00qg8bu4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 May 2022 22:46:11 +0000 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 24AMheb3023272; Tue, 10 May 2022 22:46:11 GMT Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3g00qg8btu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 May 2022 22:46:10 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24AMbhcl029930; Tue, 10 May 2022 22:46:09 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma04wdc.us.ibm.com with ESMTP id 3fwgd9r6g8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 May 2022 22:46:09 +0000 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24AMk93P28115272 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 May 2022 22:46:09 GMT Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 10CA96E05E; Tue, 10 May 2022 22:46:09 +0000 (GMT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 876166E053; Tue, 10 May 2022 22:46:08 +0000 (GMT) Received: from [9.160.179.82] (unknown [9.160.179.82]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 10 May 2022 22:46:08 +0000 (GMT) Message-ID: Date: Tue, 10 May 2022 17:46:07 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: rs6000: Prefer assigning the MMA vector operands to altivec registers [PR105556] Content-Language: en-US To: Segher Boessenkool Cc: David Edelsohn , GCC Patches References: <20220510223516.GP25951@gate.crashing.org> From: Peter Bergner In-Reply-To: <20220510223516.GP25951@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: lF27ztZC1y8umjF8-28NCazx6CeQSfCA X-Proofpoint-ORIG-GUID: AI0_DilOPtlvw4LYI-KZMeNJvtyGQraN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-10_07,2022-05-10_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 mlxscore=0 priorityscore=1501 bulkscore=0 mlxlogscore=948 phishscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205100094 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2022 22:46:14 -0000 On 5/10/22 5:35 PM, Segher Boessenkool wrote: > If you want to use this same message as commit message, you shouldn't > say "this patch". Also, try not to use lines more than 72 positions > wide (which handily is also a good maximum length for email messages, > that way it can be quoted a few times without wrapping). Sure, I can reword that. > And I assume generated code still looks at least as good otherwise? If you are asking whether we get the code we want generated with the patch, the answer is yes. Otherwise, I'm not sure what you're asking. :-) > This is more involved than just replacing one constrait with two. You > shoould say that in the changelog (and in your message). Ok, I can expand on that. > Out of interest, did you try using v,?wa (so just two alternatives, not > four)? Or did you think it wouldresult in measurably worse code? Or > did you decide it is not such bad backend code size explosion after > all :-) I have not tried that, but I will and see what happens. I'm slightly worried that since 'v' is part of 'wa', then saying '?wa' might just cancel the 'v' usage, but I'll see how it works. If it works and simplifies the patch, great! I'll report back. > Okay for trunk with a slightly better changelog. Thanks! If it doesn't work, I'll go with the code as is, modulo the changes you asked for. Thanks. Peter