From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 3E9783858D39 for ; Wed, 13 Dec 2023 12:22:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E9783858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3E9783858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702470159; cv=none; b=i+QD3W8w24Ckc+/SoFuRBcuKeY1KekgbZtCXgNVJYl0pkPW612Ohba8kwolr3rsQ3A3aGIkSsHLTXviAldO/Z4N4zBBtFU8sfPo+vTs9xWg9BN4Cse1Xjpz4IA/HL2YoOktGRUgcy7xT8K5dyc9Jmny5Wt3BNh4txLCCUHblGWo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702470159; c=relaxed/simple; bh=UbmbI7yDV+0rYwbzR+59KQf4Nvk3KcfoRvvjZ7i4+i8=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=WKSj0z+g89VnijmY8aYAVSWOlDml+wRG1qwAuAiLDMb56HguzDoJnbr6TzbB+UV1IWvnu0NZ5GVNMPIJKa4t5uCGqg1Pd+hMykive1SYYWHsyZbEeIdVzjBP4nuVcJ65nT49TSw+tzHi+X3UbVmjyzwqYYRerhucfICqD6ud8jM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDOFy-0007yW-Gz for gcc-patches@gcc.gnu.org; Wed, 13 Dec 2023 07:22:34 -0500 Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8Cxuej2oXllY6gAAA--.4023S3; Wed, 13 Dec 2023 20:22:15 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxguPzoXlleFkCAA--.15923S3; Wed, 13 Dec 2023 20:22:11 +0800 (CST) Subject: Re: [PATCH 2/3] LoongArch: Fix instruction costs [PR112936] To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn, c@jia.je References: <20231209170347.12601-2-xry111@xry111.site> <20231209170347.12601-4-xry111@xry111.site> From: chenglulu Message-ID: Date: Wed, 13 Dec 2023 20:22:11 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20231209170347.12601-4-xry111@xry111.site> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8CxguPzoXlleFkCAA--.15923S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoW7ur1xKFykury7WF47uFWUKFX_yoW8Gry3pF 9rA3W3Xr18Jr9xKrn3A3WYqrn0yr4fWr4aq3W3t3yxArs0vryjqF1ktr97uF9rJ3y8GrWY gr18Xry3uF1jywbCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVWxJr0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1c AE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8C rVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtw CIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x02 67AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr 0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUwmhF DUUUU Received-SPF: pass client-ip=114.242.206.163; envelope-from=chenglulu@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) BAYES_00=-1.9,MIME_CHARSET_FARAWAY=2.45,NICE_REPLY_A=-0.702,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_SHORT,MIME_CHARSET_FARAWAY,NICE_REPLY_A,SPF_FAIL,SPF_HELO_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: ÔÚ 2023/12/10 ÉÏÎç1:03, Xi Ruoyao дµÀ: > Replace the instruction costs in loongarch_rtx_cost_data constructor > based on micro-benchmark results on LA464 and LA664. > > This allows optimizations like "x * 17" to alsl, and "x * 68" to alsl > and slli. > > gcc/ChangeLog: > > PR target/112936 > * config/loongarch/loongarch-def.cc > (loongarch_rtx_cost_data::loongarch_rtx_cost_data): Update > instruction costs per micro-benchmark results. > (loongarch_rtx_cost_optimize_size): Set all instruction costs > to (COSTS_N_INSNS (1) + 1). > * config/loongarch/loongarch.cc (loongarch_rtx_costs): Remove > special case for multiplication when optimizing for size. > Adjust division cost when TARGET_64BIT && !TARGET_DIV32. > Account the extra cost when TARGET_CHECK_ZERO_DIV and > optimizing for speed. > > gcc/testsuite/ChangeLog > > PR target/112936 > * gcc.target/loongarch/mul-const-reduction.c: New test. > --- > gcc/config/loongarch/loongarch-def.cc | 39 ++++++++++--------- > gcc/config/loongarch/loongarch.cc | 22 +++++------ > .../loongarch/mul-const-reduction.c | 11 ++++++ > 3 files changed, 43 insertions(+), 29 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/loongarch/mul-const-reduction.c > Well, I'm curious about how the value of this cost is obtained.