From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 38AE63858D20 for ; Tue, 29 Aug 2023 15:48:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38AE63858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1bf078d5f33so36461805ad.3 for ; Tue, 29 Aug 2023 08:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1693324138; x=1693928938; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JvjsTSyJYHjaGQtRHVyXFR5SlXg2x6hifc70ZKyRs38=; b=FQmUSAOxl8eUp1yyGigvrg4WHZ+7AOFPs68nWtL+kcpcVpsI/gKJYNtjCyovhXilZl l6dPYgSY4tt4MS1ngBd/1pL2p8bAKAJcpSiIzP3aqJeBM1dkgJzD2IHjpy/rZtXUNJSz iOra7d3ISCqsa1ppCHDV2xktzMJzaWnggf7xj5eO2pzELN52C1FdkjHMU3YA/9PJDS8G aoMOUWNEQgGhswHgZvUBERsW3kcP3WkcQlXMPGKhXrvpgOUDahfdU7W8+UWktwb2G9SR gp4lWNJIEI+wZoRrszjqF+PpZGnDfewHo7W2/ElYsAEXvx7SmesjV5S8q4yU8tEpyBFf 3dDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693324138; x=1693928938; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JvjsTSyJYHjaGQtRHVyXFR5SlXg2x6hifc70ZKyRs38=; b=hXB718JsqPMjp9NGt3BnveJBPHibjNN6UKZXTx+4CIjxll+HXySxGZolzKdQDzrQPP 2z7otdxDEkCSgj0a25eSKe4FT3B2a/IjsCAikJ0B0vieFWReN7HKLyCBK6njv7FwR7um rEMJYEqxRkJiDTB40jLLG2sCSx13ypQ4ftKEMgQI5+OkqarldFh1/AIxD8EHqPJ+Alt0 p6UzariFzrJDh8t+U+uQiXK5rk21LsEv9t3/9o0FSJ9QjFgHK81AcLRUeLOBX36sq3ng ITMCI29jmFbUBDHlVGhyGphQhjVSMGsAXMMvZOwVAB/K5AvJy4fVv4vKBYDiP+geEkE2 NkvQ== X-Gm-Message-State: AOJu0YwG6SIbTGnFOy20RwPe3eas9rFTHe6tlwhBNZIcPMXKIXJ8V+WY 68sA2TynChyw+T7xFo/RmEi9Vw== X-Google-Smtp-Source: AGHT+IHvQGDLJTjCXnm8BT0Efo9nDrt1G3iEDHsbrNr7+c8z923eq7QxkskfO4FoU5/cH4skOB+nbw== X-Received: by 2002:a17:902:ecd2:b0:1b9:ebe9:5f01 with SMTP id a18-20020a170902ecd200b001b9ebe95f01mr37800806plh.19.1693324138074; Tue, 29 Aug 2023 08:48:58 -0700 (PDT) Received: from [10.0.17.144] ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id x4-20020a170902ec8400b001bc675068e2sm9488863plg.111.2023.08.29.08.48.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Aug 2023 08:48:57 -0700 (PDT) Message-ID: Date: Tue, 29 Aug 2023 08:48:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Committed] riscv: generate builtin macro for compilation with strict alignment: Content-Language: en-US To: Jeff Law , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com, Vineet Gupta References: <20230815182913.2824479-1-ewlu@rivosinc.com> <62d8c70a-43f8-c450-a8c6-05e5e58b76a6@gmail.com> From: Edwin Lu In-Reply-To: <62d8c70a-43f8-c450-a8c6-05e5e58b76a6@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/28/2023 3:40 PM, Jeff Law wrote: > > > On 8/15/23 12:29, Edwin Lu wrote: >> This patch is a modification of >> https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610115.html >> following the discussion on >> https://github.com/riscv-non-isa/riscv-c-api-doc/issues/32 >> >> Distinguish between explicit -mstrict-align and cpu tune param >> for slow_unaligned_access=true/false. >> >> Tested for regressions using rv32/64 multilib with newlib/linux >> >> gcc/ChangeLog: >> >>     * config/riscv/riscv-c.cc (riscv_cpu_cpp_builtins): >>       Generate __riscv_unaligned_avoid with value 1 or >>               __riscv_unaligned_slow with value 1 or >>               __riscv_unaligned_fast with value 1 >>     * config/riscv/riscv.cc (riscv_option_override): >>      Define riscv_user_wants_strict_align. Set >>      riscv_user_wants_strict_align to TARGET_STRICT_ALIGN >>     * config/riscv/riscv.h: Declare riscv_user_wants_strict_align >> >> gcc/testsuite/ChangeLog: >> >>     * gcc.target/riscv/attribute-1.c: Check for >>      __riscv_unaligned_slow or __riscv_unaligned_fast >>     * gcc.target/riscv/attribute-4.c: Check for >>      __riscv_unaligned_avoid >>     * gcc.target/riscv/attribute-5.c: Check for >>      __riscv_unaligned_slow or __riscv_unaligned_fast >>     * gcc.target/riscv/predef-align-1.c: New test. >>     * gcc.target/riscv/predef-align-2.c: New test. >>     * gcc.target/riscv/predef-align-3.c: New test. >>     * gcc.target/riscv/predef-align-4.c: New test. >>     * gcc.target/riscv/predef-align-5.c: New test. >>     * gcc.target/riscv/predef-align-6.c: New test. > OK.  Though I'm pretty sure the commit hooks are going to complain > about your ChangeLog :-) > > jeff I did need to do some ChangeLog formatting but was able to commit it in the end :) Edwin