From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 162B13858401 for ; Tue, 24 Aug 2021 16:28:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 162B13858401 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17OG3m7X057216; Tue, 24 Aug 2021 12:27:58 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3an1q95nw8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Aug 2021 12:27:57 -0400 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 17OG3mXg057210; Tue, 24 Aug 2021 12:27:57 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 3an1q95nvv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Aug 2021 12:27:57 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 17OGHQmc032120; Tue, 24 Aug 2021 16:27:56 GMT Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by ppma04dal.us.ibm.com with ESMTP id 3ajs4da6ka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 24 Aug 2021 16:27:56 +0000 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 17OGRt6b32047558 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 24 Aug 2021 16:27:56 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D55C6AE075; Tue, 24 Aug 2021 16:27:55 +0000 (GMT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 73967AE06B; Tue, 24 Aug 2021 16:27:55 +0000 (GMT) Received: from Bills-MacBook-Pro.local (unknown [9.163.13.183]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 24 Aug 2021 16:27:55 +0000 (GMT) Reply-To: wschmidt@linux.ibm.com Subject: Re: [PATCH 08/34] rs6000: Add Power9 builtins To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com, willschm@linux.ibm.com References: <252069d30b9f13a5e77d40fe4aee660715f00395.1627562851.git.wschmidt@linux.ibm.com> <20210823214031.GB1583@gate.crashing.org> <53cc5a6a-3d01-1a45-c548-7024d233b51d@linux.ibm.com> <20210824153832.GH1583@gate.crashing.org> From: Bill Schmidt Message-ID: Date: Tue, 24 Aug 2021 11:27:54 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210824153832.GH1583@gate.crashing.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: BhYl3r0eUvd0saLGOKdELzQoTP0LIcQc X-Proofpoint-GUID: a_n_SF41hQXOAJmMZYQ507EKW1sNoORF X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-24_05:2021-08-24, 2021-08-24 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 priorityscore=1501 phishscore=0 mlxscore=0 clxscore=1011 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108240106 X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Aug 2021 16:28:10 -0000 On 8/24/21 10:38 AM, Segher Boessenkool wrote: > Hi! > > On Tue, Aug 24, 2021 at 09:20:09AM -0500, Bill Schmidt wrote: >> On 8/23/21 4:40 PM, Segher Boessenkool wrote: >>> On Thu, Jul 29, 2021 at 08:30:55AM -0500, Bill Schmidt wrote: >>>> +; These things need some review to see whether they really require >>>> +; MASK_POWERPC64. For xsxexpdp, this seems to be fine for 32-bit, >>>> +; because the result will always fit in 32 bits and the return >>>> +; value is SImode; but the pattern currently requires TARGET_64BIT. >>> That is wrong then? It should never have TARGET_64BIT if it isn't >>> addressing memory (or the like). Did you just typo this? >> Not a typo... I was referring to the condition in the following: >> >> ;; VSX Scalar Extract Exponent Double-Precision >> (define_insn "xsxexpdp" >> [(set (match_operand:DI 0 "register_operand" "=r") >> (unspec:DI [(match_operand:DF 1 "vsx_register_operand" "wa")] >> UNSPEC_VSX_SXEXPDP))] >> "TARGET_P9_VECTOR && TARGET_64BIT" >> "xsxexpdp %0,%x1" >> [(set_attr "type" "integer")]) > That looks wrong. It should be TARGET_POWERPC64 afaics. > >>>> +; On the other hand, xsxsigdp has a result that doesn't fit in >>>> +; 32 bits, and the return value is DImode, so it seems that >>>> +; TARGET_64BIT (actually TARGET_POWERPC64) is justified. TBD. #### >>> Because xsxsigdp needs it, it makes sense to have it for xsxexpdp as >>> well, or we would get a weird holey API. > Both should have TARGET_POWERPC64 (and the underlying patterns as well > of course, we don't like ICEs so much). Yes, the enablement support I've added uses TARGET_POWERPC64.  I think we need a separate patch to fix the patterns in vsx.md. I'll take a note on that. Thanks! Bill > > Segher