From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 77218385780A; Thu, 1 Jul 2021 19:30:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77218385780A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: vHr8zxwFQoD2YcSCdHlAtqErx3AtssV0ZmNH00glk4xuJp4Eqcq4wwl3rwSHyEvBuMDcQemBVq yZmk83kVAsDd6PJ5f5EJ5o1BWF6BUiaj3HPoq8INzDvca24IXiZ3eNB4FiDqFD5fwYsDSWCHGb v3Q95rWCY2AVETKfpG7TMrvgDn4gbYt7YchLTthQoVs7Jnhp4wmAvJ3Yh5r03Hl1BktMvSg4hX 1HDNYVuykiQ+0Mht8Qa04vROmz2QIe+d0MT9LwG6wx7mx/1Y2UHZQYf5X44qNhpCgoGY3aCYln Ckw= X-IronPort-AV: E=Sophos;i="5.83,315,1616486400"; d="scan'208";a="63057950" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 01 Jul 2021 11:30:55 -0800 IronPort-SDR: tJVWRJEPlf4yOQkOT1o3uR/Hq1hOAOZQBH41ViaKhq17Ja/apqXfwxSILTpXJr44kHOO8fbaCb Gmd9I1E6U4o1H23lg/NVoBwy6rAn2oA0EU/puPCkMlDD0eCdl+FY2MBPCQmKL8XteNUqqx+64O xURHAz/D5ZmvU4dE5c+6jB2zMEpVYcO/WBFAVJDMId7oBKW1E9pw5B2L84u2HNl6Wo3LGsOiIJ vRocS4QPRkuPwK+Qz4Ff1EvhLZxNM6wAY304o4hOtBCeJmiawuhHPDpwXGCqnRjfCDL7m8LeXa tCE= Subject: Re: [Patch] Fortran: Fix bind(C) character length checks To: Tobias Burnus , gcc-patches , fortran , Paul Richard Thomas References: <602673f7-ea8e-9e71-23cb-4989ed23e079@codesourcery.com> From: Sandra Loosemore Message-ID: Date: Thu, 1 Jul 2021 13:30:48 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <602673f7-ea8e-9e71-23cb-4989ed23e079@codesourcery.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jul 2021 19:30:58 -0000 On 7/1/21 11:08 AM, Tobias Burnus wrote: > Hi all, > > this patch came up when discussing Sandra's TS29113 patch internally. > There is presumably also some overlap with José's patches. > > This patch tries to rectify the BIND(C) CHARACTER handling on the > diagnostic side, only. That is: what to accept and what > to reject for which Fortran standard. FAOD, my TS29113 testsuite just posted includes only tests for bind(c) character features that were added by TS29113, which are all failing (without this new patch from Tobias) due to the incorrect compile-time error. Those places in the tests are all currently marked with dg-bogus referencing PR 92482. I've been thinking we need to add a further large batch of tests to systematically exercise all the other character-related bind(c) functionality; all the combinations of character type, character length, dummy argument flavor, call direction, and in/out add up to perhaps 600 more things that need to be tested. :-( Of course a single testcase can test multiple things so it wouldn't require 600 actual new testcases. Anyway, I thought there was little point in starting work on that until the compiler was actually accepting the more complicated dummy argument forms. I'm a bit backlogged on other things right now but I'll give this patch a spin when I have time and if it's approved I'll adjust the TS29113 testsuite dg-bogus patterns or whatever accordingly, before reposting a cleaned-up version. -Sandra