From: Jason Merrill <jason@redhat.com>
To: "Martin Liška" <mliska@suse.cz>, "Jakub Jelinek" <jakub@redhat.com>
Cc: Nathan Sidwell <nathan@acm.org>,
Richard Biener <richard.guenther@gmail.com>,
Jonathan Wakely <jwakely.gcc@gmail.com>,
Iain Sandoe <idsandoe@googlemail.com>,
"gcc@gcc.gnu.org" <gcc@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>, Jan Hubicka <hubicka@ucw.cz>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Deprecate -frepo on gcc-9 branch (PR c++/91125).
Date: Fri, 12 Jul 2019 14:36:00 -0000 [thread overview]
Message-ID: <ebf72f71-82f1-6ff3-9d3a-7aed52e1a1bf@redhat.com> (raw)
In-Reply-To: <017bb56c-a01a-7fd2-ecd3-d84d1488d8d3@suse.cz>
On 7/12/19 8:44 AM, Martin Liška wrote:
> On 7/11/19 7:25 PM, Jason Merrill wrote:
>> On 7/11/19 3:02 AM, Jakub Jelinek wrote:
>>> On Thu, Jul 11, 2019 at 08:48:52AM +0200, Martin Liška wrote:
>>>> --- a/gcc/c-family/c-opts.c
>>>> +++ b/gcc/c-family/c-opts.c
>>>> @@ -501,6 +501,8 @@ c_common_handle_option (size_t scode, const char *arg, HOST_WIDE_INT value,
>>>> Â Â Â Â Â Â Â flag_use_repository = value;
>>>> Â Â Â Â Â Â Â if (value)
>>>> Â Â Â Â Â flag_implicit_templates = 0;
>>>> +Â Â Â Â Â warning (0, "%<-frepo%> is deprecated and will be removed "
>>>> +Â Â Â Â Â Â Â Â Â Â "in a future release");
>>>> Â Â Â Â Â Â Â break;
>>
>> Is there a reason not to condition this on OPT_Wdeprecated (which defaults to on)?
>
> Works for me.
> I'm sending updated version of the patch.
>
> Ready for gcc9 branch?
LGTM.
Jason
next prev parent reply other threads:[~2019-07-12 14:25 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7ff58510-a641-4a33-be20-28118d3b0ee5@suse.cz>
[not found] ` <CAGWvnykMCYOaY3gSGUt1BFJp-ybU9sJ463KiU4Zzysg5V-tcGw@mail.gmail.com>
[not found] ` <ac43bd46-9251-c360-b92c-52831886fc4a@suse.cz>
[not found] ` <BC1522A8-E989-448F-BB2D-7552F1111F1D@gmail.com>
[not found] ` <884b9feb-3e71-db00-8c72-8e096bf75c1e@suse.cz>
[not found] ` <CAH6eHdS-oVx-pSwsFwsnsH02biaLPyrhzv-8V23JtpfXa1=WBA@mail.gmail.com>
[not found] ` <B2D95072-A88E-4BAA-9F33-E46685EDFE9A@googlemail.com>
[not found] ` <b8d94fbd-dc73-ad66-17ca-ce34238581e3@suse.cz>
[not found] ` <CAH6eHdTPwE+6xv7n6HMsCmH-Ei=zTLN+vmAB-51=CzytmjEJFQ@mail.gmail.com>
2019-06-21 11:52 ` [PATCH] Deprecate -frepo option Martin Liška
2019-06-21 11:59 ` Jakub Jelinek
2019-06-21 14:04 ` Martin Liška
2019-06-21 14:13 ` Jakub Jelinek
2019-06-21 14:28 ` Richard Biener
2019-06-27 12:30 ` Martin Liška
2019-06-27 12:58 ` Jonathan Wakely
2019-06-27 14:22 ` Martin Liška
2019-06-27 17:53 ` Jason Merrill
2019-06-27 18:21 ` Jan Hubicka
2019-06-27 18:32 ` Iain Sandoe
2019-06-27 18:41 ` Jan Hubicka
2019-07-08 12:14 ` Martin Liška
2019-07-09 11:01 ` Richard Biener
2019-07-09 11:49 ` Nathan Sidwell
2019-07-09 13:06 ` Martin Liška
2019-07-09 17:57 ` Nathan Sidwell
2019-07-09 21:16 ` Jason Merrill
2019-07-10 11:42 ` Martin Liška
2019-07-10 12:53 ` Nathan Sidwell
2019-07-10 12:56 ` Martin Liška
2019-07-10 12:58 ` Nathan Sidwell
2019-07-10 13:22 ` Jakub Jelinek
2019-07-11 7:01 ` [PATCH] Deprecate -frepo on gcc-9 branch (PR c++/91125) Martin Liška
2019-07-11 7:17 ` Jakub Jelinek
2019-07-11 17:43 ` Jason Merrill
2019-07-12 13:00 ` Martin Liška
2019-07-12 14:36 ` Jason Merrill [this message]
2019-09-04 8:13 ` [PATCH] Deprecate -frepo option Martin Liška
2019-09-04 9:22 ` Jonathan Wakely
2019-09-04 11:20 ` Martin Liška
2019-09-04 12:57 ` Nathan Sidwell
2019-09-05 10:01 ` Richard Biener
2019-09-05 10:03 ` Martin Liška
2019-09-05 11:02 ` Nathan Sidwell
2019-09-05 11:09 ` Richard Biener
2019-09-05 11:22 ` Martin Liška
2019-09-05 12:06 ` Jonathan Wakely
2019-09-05 12:31 ` Richard Biener
2019-09-05 12:51 ` Martin Liška
2019-09-06 6:58 ` Martin Liška
2019-09-06 12:50 ` Nathan Sidwell
2019-09-06 14:48 ` Marek Polacek
2019-09-06 14:56 ` Jakub Jelinek
2019-09-06 16:03 ` Martin Liška
2019-09-09 11:02 ` Martin Liška
2019-09-09 11:08 ` Jakub Jelinek
2019-09-09 11:25 ` [PATCH] Update comment of removed options Martin Liška
2019-09-09 11:35 ` Jonathan Wakely
2019-09-09 11:39 ` Jakub Jelinek
2019-09-09 11:46 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebf72f71-82f1-6ff3-9d3a-7aed52e1a1bf@redhat.com \
--to=jason@redhat.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=idsandoe@googlemail.com \
--cc=jakub@redhat.com \
--cc=jwakely.gcc@gmail.com \
--cc=mliska@suse.cz \
--cc=nathan@acm.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).