From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2047.outbound.protection.outlook.com [40.107.15.47]) by sourceware.org (Postfix) with ESMTPS id 2CBEB3858D35 for ; Tue, 4 Jul 2023 15:29:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2CBEB3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PYU+Gs62u7ZNpFVcmdYfTUETIggebAf2aISp8oi7FzuSsuN1QxoCen3GiQRga6vH4Z/ntoLdrkUkAYPudMWX2zCMdwquhce/fYASI+H9cT7/wb2d7GX8QyNv1Xdf6fqOjC0DqdHlNRe/4yjP8G+eBMutQ2Kd/Pooa3U4m4RhMgmCL98Dt9kaYiKcDWWD9TCT1YQlK5+D1At1sfM2URqOcThLsxRh1Aky9efA3Jvz7SA+ayJSpFBzzKO+mzIfG5XUb395BLiQ2gtWgqxWXney+dWjLfuVs5uIyuuL2aOhMiMm1/kmVMiCq1e0CHgEXXcU2Sbldcm5lwS/Giaeo+Zybg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S15qJ73p3kBy4j2bKOqU4Y9LwzAwGEdSxg+325nCYek=; b=mL6eVFufpTur48W9xtH6ubCwTKqpQrwDkdXg6wrfNhcv7qPEA+F1p94N0y7D/lEL3wGZFworK9RMEjSaFK/cEQ+cqkAXcI3wzb2sy11SvXua3+7c4e1eQXNtkQ1QcsYLMq19ZBb2e30+dLJJMk9Nvy+jEmytVLXx/umd/mJ0eIvemEBQB9vBk1/Zwz0U3yWB9bx3GDidWsKhefP+8qEgXNNyydS3fB1LkZC7G1F/C4T/YadSblOjm6QL4gxeUZEF4xmn5HGaRu89mJ+96awhoRx/1cXjNlSPQcjvDKsKZYiq+OZWkWFHqlOHEFIJbT0bU4KXgtG1gTy7P6xb5RpocA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S15qJ73p3kBy4j2bKOqU4Y9LwzAwGEdSxg+325nCYek=; b=vvTZbxyLQf6yejBHfAQo5HzX9SIBvASiAQOWLFsg+NXd0fXbd0KbpK5l9xZFSc8Prbdg07IEOqBr3zKFN2JjqeSyz9VNPBjkqbhbYnuNXaoUGGiQ7yblJPnYdzfY4xiV6wQ82V47bz3u4q7+g0UIpLfXZ90KsJH9GT1HWmuXdk7WgpxRYviD1D2eWYx0ESDbL9qE6CyrDU0ujnLVvg4+IxZXbioR6KmuEqKkLu9fO+fkSwPl9hggVHzB51MQrJzyraneJPAuXLpvXGsNhqz8XgeP96TTJsdyWaIiyjgaLukzPgQd9dTsspU4pb+ISc3EfIZAeyQs+QFESjkHTkKtGw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAXPR04MB9278.eurprd04.prod.outlook.com (2603:10a6:102:2b8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 15:29:30 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::9bd3:48c9:ff58:9880%4]) with mapi id 15.20.6544.024; Tue, 4 Jul 2023 15:29:30 +0000 Message-ID: Date: Tue, 4 Jul 2023 17:29:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3] x86: make VPTERNLOG* usable on less than 512-bit operands with just AVX512F Content-Language: en-US To: Hongtao Liu Cc: "gcc-patches@gcc.gnu.org" , Kirill Yukhin , Hongtao Liu References: <169ca252-3828-b466-4d47-a8fe720ec4ef@suse.com> <7a8c5593-c53d-9c45-ffcd-c48cdd3ef911@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::8) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAXPR04MB9278:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b034afa-ecfa-4205-2987-08db7ca375e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1RRDkBhCf8QC+BOKXVgC7tqx4DkZtSDyEk9z8IUcEFJjEE8cgw297p7EjDG26zQ0sTl4HoY+v/xCPP0O4rv8S7o9UD4dHT+2S/qM+nWPvzMChPChYyAX+sKPJEYziExC4utATI+IJp1IMCeRWeUsdKq4L8dbpx9Bdppy4bMMJUIS84kTrfWs8WrWgX4ujAJhkYKV9hYcJCEIxaK3qhrSY7F42L+xcjukE99RGw3Ia0zYDB7F4QDFwLjv4hZWZAXNzKpN3Jv5HzPzRuBZ5Pueh+ZQ7Mm3WqROq2Mv1cDo4oXag6Z+46G7duZZeFsIMUM0luF+beOVKWNmabIIA0qde2pQjuB1W5XFBPiixzJ7sUWLpHvFtAbcasttUiUdupp8TfGeHNPepyM0Q/O9Y+44kL8jgZLHqXI660IR5/zYWY3xHmc6Xv8rnMn4R2AUDafw/dKqWIevccMDFoWbuAnWtIZI5NhbbA44UllOzvdXkllN7pbp3TR4n5dnatVao+XjtbQ26DmsWBQ6o30axORjeHYarv4R67UxpeHb+w75WluXRJE7fJfzvY6KTUAyAI3Cof6XIaFx7Tjb1ovJq1VSGTyJa52aUn5/nEC35bPA5wPprsDXSql7qAGpmsOsnojB9mlNcYmZD6tgCIoZL5dF/Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(136003)(39860400002)(396003)(366004)(451199021)(26005)(31686004)(478600001)(6512007)(6506007)(31696002)(86362001)(2616005)(186003)(53546011)(38100700002)(54906003)(66476007)(6916009)(66556008)(4326008)(66946007)(83380400001)(6486002)(316002)(8676002)(8936002)(41300700001)(2906002)(5660300002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QW1EQ25rdFk4QlErUFRxVXViOS9Zc21XQ3ZQakNTOWhaZzFXdGVyeWt6R0V6?= =?utf-8?B?b0NpT0s0RUhGV1drUi9RYVVaZHl4SmJHcDBYam5PejIvTW1oZWY5KzFXcFdQ?= =?utf-8?B?S295MlltMU5MN3hLTHBvbG5RL2dFQ2JZalVxUWhhZ1E2L21PSUZLSE83aE5B?= =?utf-8?B?RWFobVFYTXB2VUZNSjBkejJCTEN2S28wekREd0IwT3RwRDdrQldBR0NkdzFJ?= =?utf-8?B?ZEZkaTlIblI0QTlXRjU2Tkcyb3llTmJ4eC9TMlN4aWJzQ0RzSTcyTTdJY1JO?= =?utf-8?B?NDFkMlNBRyt0bFNOeVJCSExONEZWbks2OThLK1ZMQ0pRQS80QXJVQU85TWlJ?= =?utf-8?B?T1R2Sk9VcDJ2OE5VYnlXZmZFRWkzTDJiWU9GbGo1ejVyNUpPNmdRaXVGcWxC?= =?utf-8?B?aXhVMGx0b2EvSUdNMy8yYjJXbEZTcTNLb1V2djR3N1JtaktqcmZ4UGM5VXZk?= =?utf-8?B?SXdSc25LQmZ6SWdjUHZoYVEwc242M09vMExVM0luRzdrZzBSMzV2V0pEeDEv?= =?utf-8?B?VDUwRmFTTGRJZ2R2YTl1ZnMzaW1IZFlLNkROcG93NXBaMEJaZUZNN2V1Qkoy?= =?utf-8?B?emIvbFFOT2pIMlRVTHdKZ3NTdjVFOERNc0FpSG5ENU9nMHJCUWFaODRWQXN6?= =?utf-8?B?MGZTYklwN0YwUXloblF1UzFOVmo4Vnp4QUgxNmRZZjR2NURyVm1RRURHK3RX?= =?utf-8?B?UWpObENLZElQNEszcHJNSlQ4eUJBSlBKRlBzMG96c05Td2p3TWJyZjBON1pu?= =?utf-8?B?aVdyMlhVd045bEhlY09YM0ZJcGMyZkxleHZUNmMxK1FRTDlQS3N1RWNRVGdl?= =?utf-8?B?MkRId29ydFc2SG9YTFltUGkrLzBKK01SUThTUytNQ2xEb0REOG9YSUZvRTdl?= =?utf-8?B?THJyU2dtNWNQQ2FpTHA4UmFPWURyS3J0UzA4bVV4V3hDTzhMcFYwUHh0Wmoy?= =?utf-8?B?bnUvZ1d1K1RoenJtdjhCdG5iemZNM2F0WCt2aWhWbjRIQzNRNFhnTVM4YWZM?= =?utf-8?B?SU9waURYcWNsVHNpZFVSVThkb25RNFNINzVTMjBUNkthNU5UYVlHTjFjM2Rp?= =?utf-8?B?dUlvdjNHUmpTckx3NVBHSG1XeklTSW1taDRxRkJuU0EwTjhOZ2NlR0tCYkNZ?= =?utf-8?B?cU8vTHhINE9kN1piMyt1UXJSWDNLNDhaZXc2OEluNGpnelZaOG5kVmljenVz?= =?utf-8?B?ZWtveWx5UVR4ZzlQYjZsUDFseUFRVm5GZWxhQzdhVWVJNWVYL05EMmI2azFU?= =?utf-8?B?YjZIWVJaU295anl0QVU0Zy9nWCsrdzA2Z3V3d1FhdzQ1b1AxWU9Cb2lzdzhn?= =?utf-8?B?SHkzbWo4TWNtZTgzeEZPLzdqclRVS3FtRFN0V1JLVVBNYlFqcFlJUFkwUzl4?= =?utf-8?B?TXhIdnMxTGFUM0tmNnUzSjJBTG1hV1c4UUo5eVUrWTc1YTBvZTBBMktua1JU?= =?utf-8?B?VFVzdnREREJzYjhzM2k1TnI5Q1poRjVYQ0taYnQvQS9ORXZ2MzZDUWRWR2xw?= =?utf-8?B?bWhQTmlXSldkVVpuZ2VjaTcrc1FVU1NIM1JQcEI5R1JMekxCczBKb3RjbE5U?= =?utf-8?B?NHlabEJEbzVjcExhQWxCSnp1TVJYYjd1VXNhbkxFTmduN1Y1OUNEc1ZFY1Zy?= =?utf-8?B?S1dPa05Ga3BXSTV5YUxDdlQ2WDNic2xXQm1HdDh4Ni9haWVnYUp2SHJUektB?= =?utf-8?B?Zk5FNzcxNHZkM011MGxoUEVyNWRQazg1cENxUldoWndmemlFVWVHdjlPTkpu?= =?utf-8?B?U1lrQlFvcVlZbERNVkRmVTNVdGkzdDByMWFHVU1ySGQ3aWVvTW11Z05vWU0x?= =?utf-8?B?TkkyVTIrbEZSSUpjSjBGNkhxb0xhUEV2ZFZyVzBGRVB0MnY1ak1UOU1yK3RD?= =?utf-8?B?K0V6dGdFY3BVZDViRVYxZklMQUxtR2ZIYktLRlRzQkhVa3dHUEQzVFlaMVJi?= =?utf-8?B?TUF3blgyQ25QWWw3UmRBZityTGplUmN2NEdMOWVsLzZPVmt5VEhCMnVZMHM3?= =?utf-8?B?QjR6dU1uOEU5bmVQem9BQ1h4M3grVXhQd3g4dGRTYkpkdVFiY3EzRkhkRDRJ?= =?utf-8?B?NnU1Z3R0MGxmaktyNWxjUzR4ZDRBVUo0dVlwK3FyMGdLaFl1eHBVTmFsSk1K?= =?utf-8?Q?FVeeR3Etlfbed4oK9B6rd4Rma?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b034afa-ecfa-4205-2987-08db7ca375e0 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 15:29:30.3828 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LkqyIayuM3srqLg9TGkGDnHYWHTtHT22gabtCMvoRCMUm4/hExpplj2eDv5O/885O+AXducceb2hU/AtgEy85A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9278 X-Spam-Status: No, score=-3027.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27.06.2023 07:11, Hongtao Liu wrote: > On Tue, Jun 20, 2023 at 5:34 PM Hongtao Liu wrote: >> >> On Tue, Jun 20, 2023 at 5:03 PM Jan Beulich wrote: >>> >>> On 20.06.2023 10:33, Hongtao Liu wrote: >>>> On Tue, Jun 20, 2023 at 3:07 PM Jan Beulich via Gcc-patches >>>> wrote: >>>>> >>>>> I guess the underlying pattern, going along the lines of what >>>>> one_cmpl2 uses, can be applied elsewhere >>>>> as well. >>>> That should be guarded with !TARGET_PREFER_AVX256, let's handle that >>>> in a separate patch. >>> >>> Sure, and as indicated there are more places where similar things could >>> be done. >>> >>>>> --- /dev/null >>>>> +++ b/gcc/testsuite/gcc.target/i386/avx512f-copysign.c >>>>> @@ -0,0 +1,32 @@ >>>>> +/* { dg-do compile } */ >>>>> +/* { dg-options "-mavx512f -mno-avx512vl -O2" } */ >>>> Please explicitly add -mprefer-vector-width=512, our tester will also >>>> test unix{-m32 \-march=cascadelake,\ -march=cascadelake} which set the >>>> - mprefer-vector-width=256, -mprefer-vector-width=512 in dg-options >>>> can overwrite that. >>> >>> Oh, I see. Will do. And I expect I then also need to adjust the newly >>> added avx512f-dupv2di.c from the earlier patch. I guess I could commit >>> that option addition there as obvious? >> Still need to send out the patch, and commit as an obvious fix. >>> >>>> Others LGTM. >>> >>> May I take this as "okay with that change", or should I submit v4? >> Okay. no need for a v4 version. >>> > avx512f-copysign.c failed for -m32, we need to add -mfpmath=sse to dg-options. Oh, of course. I will take care of this, but it may take me a couple of days, as I just came back from a week of vacation. One question though: Elsewhere such tests are simply suppressed for 32-bit. Personally I'd prefer going that route, but if you think adding -mfpmath=sse is indeed better, I'll follow your request. Jan