From: Jeff Law <law@redhat.com>
To: "Bernhard Reutner-Fischer" <rep.dot.nop@gmail.com>,
"Martin Liška" <mliska@suse.cz>
Cc: Richard Biener <richard.guenther@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/4] Remove unused functions and fields.
Date: Wed, 03 Oct 2018 16:46:00 -0000 [thread overview]
Message-ID: <ec312595-757c-2f8d-4501-3ba6612ca910@redhat.com> (raw)
In-Reply-To: <20180927131337.1104d328@nbbrfq.loc>
On 9/27/18 5:13 AM, Bernhard Reutner-Fischer wrote:
>
> Although not perfect, but may i suggest to consider putting the
> attached contrib/unused_functions.py into our tree?
Do you have commit privileges? If so, go ahead and add it.
>
> Just for fun i'm attaching output for fortran, c, cp as per the
> "Examples" comment in the header of the script.
>
> sample line for cp:
> gcc/cp/cvt.o: Symbol 'cp_get_callee_fndecl(tree_node*)' declared extern but never referenced externally
Seems like it could just go away. I'd hazard a guess the introduction
of cp_get_callee_fndecl_nofold made cp_get_callee_fndecl unused and it
just wasn't caught at the time.
>
> sample for c:
> gcc/c/c-decl.o: Symbol 'pending_invalid_xref_location' declared extern but never referenced externally
> gcc/c/c-decl.o: Symbol 'pending_invalid_xref' declared extern but never referenced externally
I think these are used internally within c-decl.c, so I think they just
need their linkage changed to static.
Anyone who wants to tackle those should consider the patch pre-approved.
Jeff
next prev parent reply other threads:[~2018-10-03 16:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 7:37 [PATCH 0/4] Clean-up warnings spotted by Rtags marxin
2018-09-24 7:37 ` [PATCH 1/4] Add filter-rtags-warnings.py script marxin
2018-09-24 14:45 ` Jeff Law
2018-09-24 7:37 ` [PATCH 3/4] Fix small coding style issues (PR fortran/87394) marxin
2018-09-24 14:39 ` Jeff Law
2018-09-24 7:37 ` [PATCH 4/4] Fix scaling of a sreal number marxin
2018-09-24 14:42 ` Jeff Law
2018-09-24 7:39 ` [PATCH 2/4] Remove unused functions and fields marxin
2018-09-24 14:42 ` Jeff Law
2018-09-25 7:18 ` Martin Liška
2018-09-25 12:31 ` Richard Biener
2018-09-25 13:40 ` Jeff Law
2018-09-26 9:01 ` Martin Liška
2018-09-27 11:18 ` Bernhard Reutner-Fischer
2018-10-03 16:46 ` Jeff Law [this message]
2018-10-03 19:35 ` Bernhard Reutner-Fischer
2018-10-05 2:19 ` Bernhard Reutner-Fischer
2018-10-05 13:41 ` Martin Liška
2018-10-09 8:52 ` [PATCH] Remove dead functions and fix VMS target by moving back some functions Martin Liška
2018-10-09 22:53 ` Martin Jambor
2018-10-10 11:13 ` Martin Liška
2018-10-10 11:17 ` Martin Jambor
2018-10-18 23:55 ` [PATCH 2/4] Remove unused functions and fields Ian Lance Taylor
2018-10-22 13:05 ` Martin Liška
2018-10-22 17:50 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec312595-757c-2f8d-4501-3ba6612ca910@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
--cc=rep.dot.nop@gmail.com \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).