From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 272BD385454A for ; Mon, 21 Nov 2022 14:58:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 272BD385454A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x635.google.com with SMTP id p21so10806885plr.7 for ; Mon, 21 Nov 2022 06:58:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SN+ygfGJOmVprMQ/xx4wUWH/4o5xa8ufY9yLTfoegGg=; b=PBfMvPupgsG0pLTUuY4qQziTvfY6BQyLV9A8W620qMCHRj3RXgkPy8X1mmSrkosVwG 7ZveKMb9EHo+esThwG0gGmQjeO9fZ7RAMDg6g5Pgl41TCMTGZX4dYEymFu0uh3PLpl1H Tr284VB8JtgcgCEYXIL5lU4XBuDL+oo9H2vSPxxBM9jrB7mlScdSGkWIYqpC0bMlagbL 42E750OIeq54sH7U4wb4DB8F0GnSl0f2o9DiSCU1n3TkO8YqcdIuipRHg8j3nsJTCq7a mJP38fZjCMoZbaEK0OzA+soddKNdqjKySaC8EQyKh1/CCBJ6Nhd0ZoktYk+Ka9DiqKnI R9Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SN+ygfGJOmVprMQ/xx4wUWH/4o5xa8ufY9yLTfoegGg=; b=WLq3SfgFqytIrlxNYsSTZk8YdLe1BAJkyKSI1shzuix03Bl0/u3t9Vam2qCLdJs3un 2oBK0HnPrWV7EEHCuf2cENQ/E0Mo7SsW2pEdKYNB+2owfoZz7KvAGgImm+iEdplTrov2 HZw7y7ET1hT9dqNxcfuKnlFRAWEzEMPcGkZvyrIOOZBbryXRXnyXPaH4L4he7by5VAYO t5F1A89JUrR5ICJlYQchB4a6xH5coq7fSI4QE6gzXT4AE6vBjPC4DP7zGOMxcodhdvhY uNBJ9lIX1wDV+W0Gt8Ulv8Ps2GwI4GJ2evSUvdsC2R5WzztRVyHdVvEiLcdk5Of7ayxW u08Q== X-Gm-Message-State: ANoB5pkkh6kEn+kWdv82f4C4p2N9kpbdMNLJfQa8eaBFLKZQhTp7Arfb I3ZDuO9MwX00gpFjYJU2aaIX2yDfLCE= X-Google-Smtp-Source: AA0mqf4MtJfQSMocCj8iULY3FqqSmlVupBnVLCFLi1eTUERhGiOfEsXPW98drZ9w28oVKICx1oLBfw== X-Received: by 2002:a17:902:8548:b0:186:8398:350 with SMTP id d8-20020a170902854800b0018683980350mr12094453plo.6.1669042710990; Mon, 21 Nov 2022 06:58:30 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id u11-20020a17090a1d4b00b0020aacde1964sm10308171pju.32.2022.11.21.06.58.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 06:58:30 -0800 (PST) Message-ID: Date: Mon, 21 Nov 2022 07:58:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 1/2] Allow subtarget customization of CC1_SPEC Content-Language: en-US To: Sebastian Huber , gcc-patches@gcc.gnu.org References: <20220722130250.59766-1-sebastian.huber@embedded-brains.de> <543ce4e6-42d5-71ca-e48b-212796713f2e@embedded-brains.de> <1d880015-d502-a393-6278-4281cf64504b@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/21/22 00:26, Sebastian Huber wrote: > On 20/11/2022 17:57, Jeff Law wrote: >> >> On 10/26/22 03:34, Sebastian Huber wrote: >>> On 04/10/2022 11:47, Sebastian Huber wrote: >>>> On 08/09/2022 07:33, Sebastian Huber wrote: >>>>> On 04/08/2022 15:02, Sebastian Huber wrote: >>>>>> On 22/07/2022 15:02, Sebastian Huber wrote: >>>>>>> gcc/ChangeLog: >>>>>>> >>>>>>>     * gcc.cc (SUBTARGET_CC1_SPEC): Define if not defined. >>>>>>>     (CC1_SPEC): Define to SUBTARGET_CC1_SPEC. >>>>>>>     * config/arm/arm.h (CC1_SPEC): Remove. >>>>>>>     * config/arc/arc.h (CC1_SPEC): Append SUBTARGET_CC1_SPEC. >>>>>>>     * config/cris/cris.h (CC1_SPEC): Likewise. >>>>>>>     * config/frv/frv.h (CC1_SPEC): Likewise. >>>>>>>     * config/i386/i386.h (CC1_SPEC): Likewise. >>>>>>>     * config/ia64/ia64.h (CC1_SPEC): Likewise. >>>>>>>     * config/lm32/lm32.h (CC1_SPEC): Likewise. >>>>>>>     * config/m32r/m32r.h (CC1_SPEC): Likewise. >>>>>>>     * config/mcore/mcore.h (CC1_SPEC): Likewise. >>>>>>>     * config/microblaze/microblaze.h: Likewise. >>>>>>>     * config/nds32/nds32.h (CC1_SPEC): Likewise. >>>>>>>     * config/nios2/nios2.h (CC1_SPEC): Likewise. >>>>>>>     * config/pa/pa.h (CC1_SPEC): Likewise. >>>>>>>     * config/rs6000/sysv4.h (CC1_SPEC): Likewise. >>>>>>>     * config/rx/rx.h (CC1_SPEC): Likewise. >>>>>>>     * config/sparc/sparc.h (CC1_SPEC): Likewise. >>>>>> >>>>>> Could someone please have a look at this patch set? >>>>> >>>>> Ping >>>> >>>> Would someone mind having a look at this patch set? If there is a >>>> better approach to customize the default TLS model, then please let >>>> me know. >>> >>> It would be nice if someone could review the patch before the Stage >>> 1 ends at November 13th. >> >> Just a reminder.  The guidelines are a patch needs to be posted >> before the end of stage1 to make the deadline.  Review & integration >> can happen after the deadline. >> >> I realize the idea here is to allow RTEMS to change the default TLS >> model.  But does it also happen to make it possible to solve Keith >> Packard's issues with picolibc?  See the Aug/Sep gcc-patches archives. >> >> It looks sensible.  I assume you did a "find" to identify all the >> CC1_SPECs to change. >> >> >> OK for the trunk, > > Thanks for having a look at the patch. After looking at the patch > again, I think it can be simplified to: > > https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606841.html That's fine as well. Jeff