From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EAD9D3854558 for ; Wed, 23 Nov 2022 13:20:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EAD9D3854558 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669209605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=acrq8E4MkUuppFxg39uIApmZBM+L+8y0xTxtQ42d0ig=; b=EVvDpTsbmojngk4qKvHLYptfgYhZKehr9UEpVgactI2hhbdMz8YitpcwE4Fjijyxg1ldUK HkQnTHw9373G+6Ao6EZ39QeK+yGjcAGWwRPEyWPrs8OJuVXc8qsx0Q3QywNVThrDE5UsMS Tv5Ndx1WingsyvlTTBzCq3fcfoy6vRA= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-271-hfW99heYPWGPpJEicM2aZw-1; Wed, 23 Nov 2022 08:20:04 -0500 X-MC-Unique: hfW99heYPWGPpJEicM2aZw-1 Received: by mail-qk1-f197.google.com with SMTP id j13-20020a05620a410d00b006e08208eb31so22444658qko.3 for ; Wed, 23 Nov 2022 05:20:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=acrq8E4MkUuppFxg39uIApmZBM+L+8y0xTxtQ42d0ig=; b=6yTtD26rWlmhebNZb3KQrAtNRy/Hoq18W8VXpORdiW3kWzyU76coskT/lljKTDfpeJ /YZHdcg+MRVST+GQXIhpmADlwAJLVRy0akjPoOrvkFIR3wHinEsdrYTYLlR0uFbkfwnD IZWwyzvmMG90p8rpWpyO81yr9Cc/DQIu67qnQ0ixYIx0HaABANE7HgBD5dytT9ntaWzP kQIi/erR9CvW+j9VOw/V+KsebiXR3yFB3cSAK7gbvNVcsVTfwqczQY2MgBE5qdRe5GZN liVfwIjy8Eramgo7BfDUihGJv+WUmo2Vgpx4PivWfDeq9AQkfUjyOz0r2/7ImZ9R8TBt mGRg== X-Gm-Message-State: ANoB5pmiIq56OykI+0HHj6jIAdEB1d0RKzAgfuwB/11v+Dz9ejKq9aDc 4xvWse+Ol86POe58ciNB3z9TEIfw1mqnaP+c9xQDQ9+uT0zDOP6TSd7ozZzLl81ggrMhuLcs7p5 MQOaXGi20cdX9PHB1NA== X-Received: by 2002:ad4:5223:0:b0:4bb:59c1:3dec with SMTP id r3-20020ad45223000000b004bb59c13decmr8068005qvq.39.1669209603887; Wed, 23 Nov 2022 05:20:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf74Iuh1u92h0Z2ZrM6KJ94FCnWILmTrdMONLjFFtqd7cJeKxjmVIUJ7Raamb6PZwV1AdEcUow== X-Received: by 2002:ad4:5223:0:b0:4bb:59c1:3dec with SMTP id r3-20020ad45223000000b004bb59c13decmr8067987qvq.39.1669209603668; Wed, 23 Nov 2022 05:20:03 -0800 (PST) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id s15-20020a05620a29cf00b006fbbffd08f9sm12091083qkp.87.2022.11.23.05.20.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 05:20:03 -0800 (PST) Message-ID: Subject: Re: [PATCH] diagnostics: Fix selftest ICE in certain locales [PR107722] From: David Malcolm To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Date: Wed, 23 Nov 2022 08:20:01 -0500 In-Reply-To: References: User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 2022-11-23 at 09:51 +0100, Jakub Jelinek wrote: > Hi! >=20 > As reported in the PR, since special_fname_builtin () call has been > introduced, the diagnostics code compares filename against _(" in>") > rather than "", which means that if self tests are > performed > with the string being translated, one self-test fails. > The following patch fixes that. >=20 > Bootstrapped/regtested on x86_64-linux and i686-linux (with normal C > locale) > and by the reporter in German, where it fixes the problem.=C2=A0 Ok for > trunk? OK Thanks Dave