From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by sourceware.org (Postfix) with ESMTPS id 972D33858D37 for ; Tue, 27 Dec 2022 15:11:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 972D33858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-io1-xd34.google.com with SMTP id g20so7015633iob.2 for ; Tue, 27 Dec 2022 07:11:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=O8Ymj8b8oWVpb9KQP99tAAaIbi6HtD8fYjmgaapzVig=; b=e8F+SaWrnEuX5X8qhNGh/bQGmH4Kwk5M/ogpdCLDk3ey4qzJS0EABq8OA4H2VF2Ov6 pUwHqEQ7Jp9vnb8bjgGfOttcgfKCwPQAsFsrMvHSgE4E5v4mnsY/vUNkyRQxxTSsJQPS VnxzPIL7ScJOaPWiuIrcairyFf9sZak0BbMCUaJ3aaB+C1q4s5+wQByPzcpzMIynQ1kT UzM0zzPuRQnCCV8raWosPdlIFpPEP9QX+2uYxXIGgO7UZ0Xqkevq3A7wOuG1CWQSSiPG 2/h+8Q6MY3FLLK8kbDgueR0n01+BAaRFMFLfHriuFyEJOTRUOXgHX0y8b7RoS1tEKJOc 5E7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O8Ymj8b8oWVpb9KQP99tAAaIbi6HtD8fYjmgaapzVig=; b=qOJT13NSdYbLBGqc8t1nbJG893wSs4OwBEz8AMASTD1YqVNQdqCq0iVKLpwJp4FLjQ hLsJHb/6sRti5V6eQ/t/7wOZLQVhf2zz9k4UWGsvMny3zjeGhQ2p0yDGZZqDKDe4I4kI 5v68gxk/56xf4EJPyQyS8Ed19N6291aFbxtLHGMtM/Pyex4Jd5hX1sOwn7VRbFN87hv3 fr0fbhb0CJR/UnB6btZLRejZaxg19bKz04l/B07GrVGWU1Cx0cIwI4v1vaSbBTj5rUaU h6/wZqIxxdz8ZTaulTDhNae6hZzfnd4BK5N3rUYQIO2WiWIX38vGAOoZnMiFoGTJtG2J wtbA== X-Gm-Message-State: AFqh2kooEyBbYQjgD7AMOA95dIVfLy6DIEnDLErSAoeKSK5vxCoRnKVF xyu/ek9iUj5dwajQHSjC3io= X-Google-Smtp-Source: AMrXdXtBVblAaoPF0biIK/mCeP2KI2LnjSQoIONk20byjpiKwmRAXiQzZEkqpOKYdeBbqpwP883Pdg== X-Received: by 2002:a5e:c307:0:b0:6df:df0c:6ce1 with SMTP id a7-20020a5ec307000000b006dfdf0c6ce1mr14777959iok.10.1672153881715; Tue, 27 Dec 2022 07:11:21 -0800 (PST) Received: from [172.31.1.18] (65-130-81-249.slkc.qwest.net. [65.130.81.249]) by smtp.gmail.com with ESMTPSA id e21-20020a6bf115000000b006d8b7bcaa6esm5067381iog.4.2022.12.27.07.11.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Dec 2022 07:11:21 -0800 (PST) Message-ID: Date: Tue, 27 Dec 2022 08:11:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [01/13] scoped tables: insert before further lookups Content-Language: en-US To: Alexandre Oliva , gcc-patches@gcc.gnu.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/26/22 21:17, Alexandre Oliva via Gcc-patches wrote: > > Avoid hash table lookups between requesting an insert and storing the > inserted value in avail_exprs_stack. Lookups before the insert is > completed could fail to find double-hashed elements. > > Regstrapped on x86_64-linux-gnu. Ok to install? > > > for gcc/ChangeLog > > * tree-ssa-scopedtables.cc > (avail_exprs_stack::lookup_avail_expr): Finish hash table > insertion before further lookups. Thanks. OK. Jeff