From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id BFE143857831 for ; Wed, 4 May 2022 13:31:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFE143857831 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AF098210E5; Wed, 4 May 2022 13:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1651671092; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NvV0XqD4jMt/OxNfCYiQkqmyUqOsNZPv6cverTqOJkY=; b=2ug/JDXYjp05Txhp6tIvx3JQK8ueZaKM0++pxHLW2kqWekYI6biufKwJPNrFvDIKha6KCx KztO5OvhzAifYDJ5n1b6csrVTA7zkH0Ql4OK5VZuynAb+kHNsq+7dnZpQzbXzwXpt75WuH JI+P6zmpnVOZigS5srPHz4QxI5w8W/U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1651671092; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NvV0XqD4jMt/OxNfCYiQkqmyUqOsNZPv6cverTqOJkY=; b=7xi9069u9DXP98dqesDBBfIjji0y/c8oY0kyE4816eGDWWjI9HvHVv95Sa9PrxD+aI+rWm rARrfaC8KBiV8PDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 96CCA132C4; Wed, 4 May 2022 13:31:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lfbPIzSAcmIeewAAMHmgww (envelope-from ); Wed, 04 May 2022 13:31:32 +0000 Message-ID: Date: Wed, 4 May 2022 15:31:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] lto-plugin: add support for feature detection Content-Language: en-US To: Alexander Monakov Cc: gcc-patches@gcc.gnu.org, Jan Hubicka References: <63633ead-aa7e-c424-9851-ac332ac13df3@suse.cz> <27841a42-baef-d53e-c601-ad265030854d@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 13:31:35 -0000 On 5/4/22 15:10, Alexander Monakov wrote: > On Wed, 4 May 2022, Martin Liška wrote: > >> On 5/4/22 14:32, Alexander Monakov wrote: >>> On Wed, 4 May 2022, Martin Liška wrote: >>> >>>> The patch is a follow-up of the discussion we've got in: >>>> https://gcc.gnu.org/pipermail/gcc-patches/2022-May/593901.html >>>> >>>> Mold linker would appreciate knowing in advance if get_symbols_v3 is supported >>>> by a GCC plug-in or not. > > Out of curiousity, I looked at mold, and I don't understand what problem this > detection is solving, nor why this is the best way to solve that. Was there > some discussion with mold author I should check out? Sure, please take a look at this issue: https://github.com/rui314/mold/issues/454#issuecomment-1116849458 > > Note that mold takes this not only as 'v3 API is supported', but, more > importantly, as 'v2 entrypoint will not be called'. Yes, if they register get_symbols_v3, then it will be called. That's how the plug-in works. Martin > > Alexander