public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jlaw@ventanamicro.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [committed] [NFC] Fix riscv_init_cumulative_args for unused arguments
Date: Sun, 21 Jan 2024 15:48:33 -0700	[thread overview]
Message-ID: <ecc83f90-bd6a-4668-9408-9ad539db6233@ventanamicro.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]


The signature was still using ATTRIBUTE_UNUSED and actually marked one 
of the used arguments with ATTRIBUTE_UNUSED.

This patch drops the decorations and instead remove the name of 
arguments which are actually unused which is the preferred way to handle 
this now when we can.

Bootstrapped.  I didn't have test results on the platform where I 
bootstrapped, so no results to compare against.  Given its NFC, I think 
we're OK without the regression results.

Pushed to the trunk.
jeff

[-- Attachment #2: P --]
[-- Type: text/plain, Size: 620 bytes --]

diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 1f9546f4d3e..3ba45ffaa74 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -4873,11 +4873,7 @@ riscv_pass_fpr_pair (machine_mode mode, unsigned regno1,
    For a library call, FNTYPE is 0.  */
 
 void
-riscv_init_cumulative_args (CUMULATIVE_ARGS *cum,
-			    tree fntype ATTRIBUTE_UNUSED,
-			    rtx libname ATTRIBUTE_UNUSED,
-			    tree fndecl ATTRIBUTE_UNUSED,
-			    int caller ATTRIBUTE_UNUSED)
+riscv_init_cumulative_args (CUMULATIVE_ARGS *cum, tree fntype, rtx, tree, int)
 {
   memset (cum, 0, sizeof (*cum));
 

                 reply	other threads:[~2024-01-21 22:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecc83f90-bd6a-4668-9408-9ad539db6233@ventanamicro.com \
    --to=jlaw@ventanamicro.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).