From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by sourceware.org (Postfix) with ESMTPS id CD17F3858CDB for ; Wed, 8 Nov 2023 21:28:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CD17F3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CD17F3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699478898; cv=none; b=Ot3ZsM+GqIOSv/NWC/NjiXZ7f7w6WI5GrJ3qxMPjBG3fMaMwDyKEXbb0UUFAIMIEpX5lw1XlsACdxRnS6h5Q9SuPtRBYXi9iNj6TCTH3IVeMYjYJAnSEZb5qC4ygLQ2kh59Cbh3E9pNhI87x5IuPz03us0UAkXg2KjTJobtfvCc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699478898; c=relaxed/simple; bh=v57hnFbxwpfqg7c9TX1cLMhv9Z3O/EgZezQI6WZvrxI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=S0K6Q7m7u/rDokT/u21/yQtiEo1aaYqOfysyX5bAdF5ohKovAo85cYQUhQXP9r4gJKkWquOP0WVStIp8vPM2j41iqGSj/TXzxy09IErfr36ViHWbQRca3RAa0tSsNSS1XZOfV7jF6uL6rt+RILKJ6GQyp3NmdSyp5LE2/qEm3SM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-7a694a365d9so6760439f.0 for ; Wed, 08 Nov 2023 13:28:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699478896; x=1700083696; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bhMWw0Ci77InGhReOV0vyEO2wh6VQ94LxvFXcyT0RE0=; b=Gc543fNtPUoxrWSQr7OF1sZh0Op0ThgYR9dp0/1Ai1wZRhWC7WmJ1uFhCHtzKeKm4d HV1saFF760FFHs1gxDpKWn4zuqOQRkJoeouVsuT2dEhAFXpLjKFvf86VATpfWLg89IYO SJJUxJ33g4WCg6JTqCd2Dm42ah7kItPa/BXEZU/G4TMeywtMifBEZTJlgSY0Q5F41iBy q3XXJkglgF7ftfUdKsmMDgSjRq93gZeGVNcLPICsAp48okEMoga6PapFKLsZEvjgXDGi 9T9zxDm87gmt9aERbonXjQF6fIzTPCb3z8WhRNlOdEFaZ/1A7rK/79KKSpCpp6xKkIvz +lBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699478896; x=1700083696; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bhMWw0Ci77InGhReOV0vyEO2wh6VQ94LxvFXcyT0RE0=; b=bN2Wj0tOVRiOygJf8lYkYpkELBWipxbdczELOqy9R9V9+OOyC6/Gl2xhOPmmhyFVu/ prER0wk+ii2a5kcQeoJf8pv446asJh4X0GQOdixefguRwMKTMV2i4QZNC0DcRgZLMsZx kgD1VmD07yhC3tt/3lsiE4O5EpBQ3hiSaqsre9dnLyKsgbfsicwCa4PPs4FFEPo9Dr99 zb3fGHLyPZ7MC2VQVh70mZ2vif+D+zrQQnom4j/ak9BgcdGs81DvVtIfA+2r4Bm20vsm WU4Ixz/QHBHdb0MG/nhd+o9GYwFizEtBb6VbQw/lX/jxcoaANsE71GfCj4cLZovoU59R KNxw== X-Gm-Message-State: AOJu0Yzz6tF0wJmv8jWW3fyP+viC1DeuuefocwZ1meRxGpvLcGwEDGOy Vx7WIyILSgwdpo+7oISnQ5zppIoLodgOoA== X-Google-Smtp-Source: AGHT+IE9bTclEFe7ib0Z4Pzo8N4PmeHqGmAchJT0G9ZFjzNoKyxRBPoU7IWCLRX2BSuU3/VvsPPqPg== X-Received: by 2002:a05:6e02:1a65:b0:359:ca5f:5103 with SMTP id w5-20020a056e021a6500b00359ca5f5103mr2983492ilv.6.1699478895783; Wed, 08 Nov 2023 13:28:15 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id e2-20020a921e02000000b0034f1bb427dbsm4042051ile.60.2023.11.08.13.28.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Nov 2023 13:28:15 -0800 (PST) Message-ID: Date: Wed, 8 Nov 2023 14:28:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] skip debug stmts when assigning locus discriminators Content-Language: en-US To: Alexandre Oliva , gcc-patches@gcc.gnu.org Cc: Eugene Rozenfeld References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/8/23 08:51, Alexandre Oliva wrote: > > c-c++-common/goacc/kernels-loop-g.c has been failing (compare-debug) > on i686-linux-gnu since r13-3172, because the implementation enabled > debug stmts to cause discriminators to be assigned differently, and > the discriminators are printed in the .gkd dumps that -fcompare-debug > compares. > > This patch prevents debug stmts from affecting the discriminators in > nondebug stmts, but enables debug stmts to get discriminators just as > nondebug stmts would if their line numbers match. > > I suppose we could arrange for discriminators to be omitted from the > -fcompare-debug dumps, but keeping discriminators in sync is probably > good to avoid other potential sources of divergence between debug and > nondebug. > > Regstrapped on x86_64-linux-gnu, also tested with gcc-13 on i686- and > x86_64-. Ok to install? > > (Eugene, I suppose what's special about this testcase, that may not > apply to most other uses of assign_discriminators, is that goacc creates > new functions out of already optimized code. I think > assign_discriminators may not be suitable for new functions, with code > that isn't exactly pristinely in-order. WDYT?) > > > for gcc/ChangeLog > > * tree-cfg.cc (assign_discriminators): Handle debug stmts. OK jeff