From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 484C2387474A for ; Fri, 24 Jun 2022 18:12:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 484C2387474A Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-372-GUW6gl8HP7qQMaQw856PXA-1; Fri, 24 Jun 2022 14:12:54 -0400 X-MC-Unique: GUW6gl8HP7qQMaQw856PXA-1 Received: by mail-qk1-f200.google.com with SMTP id w16-20020a376210000000b006af059b17b7so2559562qkb.12 for ; Fri, 24 Jun 2022 11:12:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=tgaH1INFZmFJQ0Xkr3CtFVrJdXGMnBBCdhiQaz/mTo8=; b=3T99dOeSII+z0j1+fWQ5ZxujqIC55Std45eNobBhMB/H1J/Z89Z1JFS2lDE7yqteou t3iQ5+IfZwTTc/2LJkaFXY1kLrcy0X9PiCyMceGouSgCV5HbzD6MWnKf15mTDlCcbWxb f4cubRHWb2mE8HAlVviLlUzi5fBffoNNqNAkHzOrd+SD4AuYDs18C5ofUVDGyl5ntOis YeJa9pQ+tre/TdCUhMUSDRm1x6kEc7r9fEmhJzBEUpXwWkyxuTg1Wr8URHuQDagCj8ne tCyj4RED6fEVzIGPtTxZZBdlONFhZPYtktxrBfUCc3OtrkdXv9YbL5dY18F/6GwPdGCb mq9Q== X-Gm-Message-State: AJIora8SFLaMpT5IB55GTV2vIrs2lyUttJad1VkkMexRYyLBhGuNY5al 3gMkCWhzK5sCaGvBxLxhQ7OUtVkKs6LY0CWFqIu8ckqIJ0augfhMAkqjDndnSDjH8dl8gyrl9Rk 1js1jcDUAllHOpGIFH3bkY0bRLOhcSY/u4DVfXgWpEY7nWkH+QVICc/1xHbDbSt0yrDAdOg== X-Received: by 2002:a05:620a:2590:b0:6ab:91fd:438 with SMTP id x16-20020a05620a259000b006ab91fd0438mr405464qko.312.1656094372961; Fri, 24 Jun 2022 11:12:52 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sYiHrTWr/z0fqdICr0Vs41M260xAUzgyOJ+Rl3aJwgUtkCvl/i9BoqB5eOKBnoBBjl/ajlxw== X-Received: by 2002:a05:620a:2590:b0:6ab:91fd:438 with SMTP id x16-20020a05620a259000b006ab91fd0438mr405442qko.312.1656094372574; Fri, 24 Jun 2022 11:12:52 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id u8-20020a05622a17c800b0031776d4ae3asm1739806qtk.60.2022.06.24.11.12.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 11:12:51 -0700 (PDT) Message-ID: Subject: PING^2 : Re: [PATCH 03/10] expr.cc: use final/override on op_by_pieces_d vfuncs From: David Malcolm To: gcc-patches@gcc.gnu.org Date: Fri, 24 Jun 2022 14:12:50 -0400 In-Reply-To: <55c38eed09f7896673e3c6ba8bd6d63405174c6d.camel@redhat.com> References: <20220523192834.3785673-1-dmalcolm@redhat.com> <20220523192834.3785673-4-dmalcolm@redhat.com> <55c38eed09f7896673e3c6ba8bd6d63405174c6d.camel@redhat.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 18:12:57 -0000 On Mon, 2022-06-13 at 14:25 -0400, David Malcolm wrote: > Ping on this patch: >   https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595434.html > > OK for trunk? > > Thanks > Dave > > On Mon, 2022-05-23 at 15:28 -0400, David Malcolm wrote: > > gcc/ChangeLog: > >         * expr.cc: Add "final" and "override" to op_by_pieces_d > > vfunc > >         implementations as appropriate. > > > > Signed-off-by: David Malcolm > > --- > >  gcc/expr.cc | 14 +++++++------- > >  1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/gcc/expr.cc b/gcc/expr.cc > > index 7197996cec7..ce58728862a 100644 > > --- a/gcc/expr.cc > > +++ b/gcc/expr.cc > > @@ -1357,8 +1357,8 @@ op_by_pieces_d::run () > >  class move_by_pieces_d : public op_by_pieces_d > >  { > >    insn_gen_fn m_gen_fun; > > -  void generate (rtx, rtx, machine_mode); > > -  bool prepare_mode (machine_mode, unsigned int); > > +  void generate (rtx, rtx, machine_mode) final override; > > +  bool prepare_mode (machine_mode, unsigned int) final override; > >   > >   public: > >    move_by_pieces_d (rtx to, rtx from, unsigned HOST_WIDE_INT len, > > @@ -1453,8 +1453,8 @@ move_by_pieces (rtx to, rtx from, unsigned > > HOST_WIDE_INT len, > >  class store_by_pieces_d : public op_by_pieces_d > >  { > >    insn_gen_fn m_gen_fun; > > -  void generate (rtx, rtx, machine_mode); > > -  bool prepare_mode (machine_mode, unsigned int); > > +  void generate (rtx, rtx, machine_mode) final override; > > +  bool prepare_mode (machine_mode, unsigned int) final override; > >   > >   public: > >    store_by_pieces_d (rtx to, by_pieces_constfn cfn, void > > *cfn_data, > > @@ -1650,9 +1650,9 @@ class compare_by_pieces_d : public > > op_by_pieces_d > >    rtx m_accumulator; > >    int m_count, m_batch; > >   > > -  void generate (rtx, rtx, machine_mode); > > -  bool prepare_mode (machine_mode, unsigned int); > > -  void finish_mode (machine_mode); > > +  void generate (rtx, rtx, machine_mode) final override; > > +  bool prepare_mode (machine_mode, unsigned int) final override; > > +  void finish_mode (machine_mode) final override; > >   public: > >    compare_by_pieces_d (rtx op0, rtx op1, by_pieces_constfn > > op1_cfn, > >                        void *op1_cfn_data, HOST_WIDE_INT len, int > > align, >