From: Jonathan Yong <10walls@gmail.com>
To: Evgeny Karpov <Evgeny.Karpov@microsoft.com>,
Uros Bizjak <ubizjak@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"richard.sandiford@arm.com" <richard.sandiford@arm.com>,
"Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>,
Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
Radek Barton <radek.barton@microsoft.com>
Subject: Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64
Date: Sat, 8 Jun 2024 01:59:59 +0000 [thread overview]
Message-ID: <eda5392e-2b12-4587-8e0f-63505d0b26e4@gmail.com> (raw)
In-Reply-To: <DBBPR83MB0613DAFAE474005B4DA9E176F8FA2@DBBPR83MB0613.EURPRD83.prod.outlook.com>
On 6/6/24 09:23, Evgeny Karpov wrote:
> Thursday, June 6, 2024 1:42 AM
> Jonathan Yong <10walls@gmail.com> wrote:
>>
>> Where is HAVE_64BIT_POINTERS used?
>>
>
> Sorry, it was missed in the posted changes for review.
>
> Regards,
> Evgeny
>
> diff --git a/gcc/config/mingw/mingw32.h b/gcc/config/mingw/mingw32.h
> index 8a6f0e8e8a5..0c9d5424942 100644
> --- a/gcc/config/mingw/mingw32.h
> +++ b/gcc/config/mingw/mingw32.h
> @@ -82,7 +82,7 @@ along with GCC; see the file COPYING3. If not see
> #endif
>
> #undef SUB_LINK_ENTRY
> -#if TARGET_64BIT_DEFAULT || defined (TARGET_AARCH64_MS_ABI)
> +#if HAVE_64BIT_POINTERS
> #define SUB_LINK_ENTRY SUB_LINK_ENTRY64
> #else
> #define SUB_LINK_ENTRY SUB_LINK_ENTRY32
>
Looks OK to me.
next prev parent reply other threads:[~2024-06-08 2:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 21:35 Evgeny Karpov
2024-04-18 21:41 ` [PATCH v1 1/6] Move mingw_* declarations to the mingw folder Evgeny Karpov
2024-04-18 21:43 ` [PATCH v1 2/6] Extract ix86 dllimport implementation to mingw Evgeny Karpov
2024-05-22 11:05 ` Richard Sandiford
2024-05-22 14:32 ` Evgeny Karpov
2024-05-23 8:35 ` Uros Bizjak
2024-05-23 8:41 ` Uros Bizjak
2024-05-23 17:53 ` Evgeny Karpov
2024-05-23 19:37 ` Uros Bizjak
2024-04-18 21:45 ` [PATCH v1 3/6] Rename functions for reuse in AArch64 Evgeny Karpov
2024-05-22 11:46 ` Richard Sandiford
2024-04-18 21:46 ` [PATCH v1 4/6] aarch64: Add selectany attribute handling Evgeny Karpov
2024-05-22 11:57 ` Richard Sandiford
2024-04-18 21:48 ` [PATCH v1 5/6] Adjust DLL import/export implementation for AArch64 Evgeny Karpov
2024-05-22 12:07 ` Richard Sandiford
2024-04-18 21:49 ` [PATCH v1 6/6] aarch64: Add DLL import/export to AArch64 target Evgeny Karpov
2024-06-04 20:10 ` [PATCH v1 0/6] Add DLL import/export implementation to AArch64 Evgeny Karpov
2024-06-05 6:01 ` Uros Bizjak
2024-06-05 23:41 ` Jonathan Yong
2024-06-06 9:23 ` Evgeny Karpov
2024-06-08 1:59 ` Jonathan Yong [this message]
2024-06-05 8:13 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eda5392e-2b12-4587-8e0f-63505d0b26e4@gmail.com \
--to=10walls@gmail.com \
--cc=Evgeny.Karpov@microsoft.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=maxim.kuvyrkov@linaro.org \
--cc=radek.barton@microsoft.com \
--cc=richard.sandiford@arm.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).