From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id C24A73858D20 for ; Sat, 8 Jun 2024 02:00:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C24A73858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C24A73858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717812008; cv=none; b=XhbemmbrHdS6ekc5TjBnvZXWfY8JyDjqJzGJJB0sGC+IUXjJg0zxTrr7q7yBzzKTjHSK4dn8Y4FmJnQKSlOgnsSkKWH9861RhxQElsmHf9kBuF8gMZgwixKvLtCJe3TguFM8MTGHXrzgCAECxV3iZqdcCj5C9lMwASvF4gFiEXQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717812008; c=relaxed/simple; bh=dmngVH0HEpN7SE88coJ6H+0jZ9bKJAxcfBnjN4FijEI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=t2K/jzm8JwYNmi76EOaixrq4DwJAQi1S1qfJGUKgeJca9oWJ3GjQmQfzXTA4wzB/QSlWLBuBPzv9PpFOanqa0mWdqzf/Cot6Ssvw80/BE9XRn8UkDJp1nz5EhzHnMTuaXrrpcbBoakS8SRS0ifKZrwihz/Tpw7EVvf2cDcw1+jk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1f47f07acd3so25720405ad.0 for ; Fri, 07 Jun 2024 19:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717812004; x=1718416804; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=qe2AlZF1T3XV3DONk+GCHWn/QjQOEXH0ZYyhHnvlwWc=; b=hWsj+vPdA8OtbDk+ExrPnKq/nHsGxmsFyKOdJ1xMvfoND5fqGubz0KbhjlSCQmhGgj 1SwP9nRVaBr8T5SJdu8ql9JI9qwc726H3QtM1CoQRRcj9kjxANo6OqREBB0zvNUVw4Ep zrZUeXpOi1/bWkiSKEySH5IoIPNi1D0SR5e7j9MlxCHG2S7SfsJOVvfHoGD2u/3nftaG Elu1BqEWUhRc5nskt1rUMizF6sVRyCxQ+HO3h5yv6FW//PzWgG5Zv2gzeETiR0VaBr5h mcGlagotowtDigv2TKt2qqoqW9LKJ8PAad3/Z/qLk9DbtNf2a15UJr2lff4gLLxt+gXf YfhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717812004; x=1718416804; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qe2AlZF1T3XV3DONk+GCHWn/QjQOEXH0ZYyhHnvlwWc=; b=lUKxXQhW8eG8C5tDvqe6RXszHfoO8YtHQENI0Y4+KPlpWFOo+MXabVusS03gBguR8j STyRKpbDbnROlO4OOMAe6OPepLyfM464lJmqzDfCREvUosIIRdZLRCxaealP9bTRMbzj yIjLkFJBhim7PBwBWTfwCy0BZBm4evIsxOWFXLIxGE5e9ZYOecOmEyCFsxGGWHdt0jZy R7Tj1MjDYgB29f1LLpjtN8Ece4gVQFiuadQVRcOM8cU+gIhTttcgL5GoNiEpAIvlsELI ECUqBR3MVQ+L2UFH96/T7znXH04tAkhaMGT36GlAVVXochBcpilG3ASLW2dHDCLUvvPZ OQqg== X-Gm-Message-State: AOJu0YzEMiY9aX8NoqczlFZBgRmSwzTEcY8qBH6UCXwxS9UXHtIEQS1O eJgeNRUA+vEuSC3MdAhVb1fwDTnfWRCd4Lm58dfdHIQ0d539YcDE X-Google-Smtp-Source: AGHT+IFhQKCA3FA0ouacavmhLwFDh3YdTRafXZ97PEdV8UAnQsMq8YFUG4Lu9N5/0we9/1PYGuJMHQ== X-Received: by 2002:a17:903:2445:b0:1f6:70fe:76bf with SMTP id d9443c01a7336-1f6d02d1a99mr49810265ad.14.1717812003565; Fri, 07 Jun 2024 19:00:03 -0700 (PDT) Received: from ?IPV6:2001:f40:919::2cb3? ([2001:f40:919::2cb3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6bd76d049sm42023635ad.99.2024.06.07.19.00.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jun 2024 19:00:03 -0700 (PDT) Message-ID: Date: Sat, 8 Jun 2024 01:59:59 +0000 MIME-Version: 1.0 User-Agent: Betterbird (Linux) Subject: Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64 To: Evgeny Karpov , Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" , "richard.sandiford@arm.com" , "Richard Earnshaw (lists)" , Maxim Kuvyrkov , Radek Barton References: <4293344a-4961-4179-a408-af99a830115c@gmail.com> From: Jonathan Yong <10walls@gmail.com> Content-Language: en-US Autocrypt: addr=10walls@gmail.com; keydata= xsFNBFDEdwIBEACSrmywJMpgYlgJa0HJ1AFu9tQp8yVpVS21EfnrSK16TS6PoW/JS78D5CYx pshPzr1iil8yeL8/val1yXkI8uNZjMnhLxMBU5C7WEMCeY/h760btG3bZZ5BMCNCkC0Yfrtv JJQDEyv1H+p1U7yMFRyxNtMjaf6QDzoRjTVOzO6mtNMZWYnlhzC54etiVt3HQ4jKOlKbI+dw jigIw8B1SZ+xWcukAHRMBcIZYLjbnAI/XNu796pfwh6QEhJjr8EpvyNjdHLFSMMuyUPO/a3s r/jkFSTpqt5lr9jWejdQwe7e8WtbC+euv++fH1B9Yz42259kLxgH+aHk6lWX3epIIx3w17rG faMrFrINjXEBGLLOQkIy2LtBLYRU2NhDg+VSDOEwAsiOVZs1EHpSNF5GV12L8SFiNtVToHxL RpObNpYIHBkDFzx9gvQfX5Kocx5XFhBiNfTjdxBOjopLzQHpfCSo3fzSqc7zpscqOw3uni7G IN86fI8h3wSV44dQ4yaervnL2kZykRyWL5y1C9WDfjzljTIeLB6gK/gBbrsuKuVC42r6xAK9 yC9pL0Trf7+GLJ9UF4WGnJ5IvfVpZ7gtBMjWOpiwewTprdBNwhLsVSep9Vqg/cbtmG6AnpzN tMsLEWAwDpgaFa5KqlehgUCuMlEdU6LhvSd0cJ/pqKwwzxEiLwARAQABzRlqb25feSA8MTB3 YWxsc0BnbWFpbC5jb20+wsGVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgBYh BOUK3Z2wV/T6ZOG2z3E7X+KcFF1FBQJkv8QIBQkXsIUGAAoJEHE7X+KcFF1F4uEQAJKbrHtj r648MMV+rkwrpB0DD8hqP+gammZcozvO2SQmJjN6bLHDquPkgqGe2GkDm+2FAxJ0OogRKGki Fak4d+fkAFxPwEhSSHZG360ODypL82NQ/v2GWTikaKr6d2sC5zNfif84ejrT1uZbzMFiKo6u BkerQsqoOuhE/dW3HTIgHrQqTM15sjBbeg4YQC1nmQeWlAK6rMkzNLQefmbFpbUQW9OBFEFr /wSI8GnJYyoJmtBf+Kl5n/fghYc4tcUfx8JB92ktkirO+TuFEsGXqU7RwxaO0PnjYMDtR6m5 UYVumzYQEeAbHcbuj95tIUpNwoyyuHZMOjL4/xaagGU9Isb4POyQVviwYMSAZh+k08BMpiQY UbGYxiDrtV6WQBOPpX3MfeJ6GlLXd07UCDcV3FKBHcHllfaSxEmbfBAuNEVxpG8FXaCfyJ8c ysdoSPmNo9ExpXKIcIOssfKJldHFvYO/egtakO9LGY4fOExRA4aEtsKml9TeRqHwr94bX516 VsDEkndFKwZkh5HwaitcuHD222gntr3ozquQ3xjm7Sh/0JqyypslVzPGAPQZcCBeg0Ct6ZUc ovAYcx/Pxv5xIissAoUti6PVpF2EcuBiPO9XgpVe8mUhYdJm29hZMkuxg++cNHbQgzPUicfz 9tsVWNkBOEAFZ7yrJcPQ9DO/rg1wzsFNBFDEdwIBEACsXcBns4YGVTUGMVKVGEocPffmAhAY 89XSk1c1qWPngieUtZ2GoiG+a8IKAqYIjfpuV/YXX8i9mXuGAGJvf6rRhpPos8v76y3qoFFr PsFjNaiTTTvPn1oNRT+Br5KWjJaDomGkmQe5bGrok6ETK4VgRdYWPib7IbTLUX1rzfaKvDP2 19HTsdWj/cdE3QGTZjekJUiJqgqSS8SmaBNtFm2T18r3gdx6+Xq0kJPW421IaXtuxbyD3MTB VJYEfY+rEvVfMUi9rvsfCG0djJOh8954D8AhVY58x7aszhHddTeQlXxUdwNpyJFFoFFhpj0L vmhCH84eaf+9eW8VqegPDzE2MJ/Oe+bftYS9qtIx4MMHRU5Wl7g2x3QUhsmyev3BmhBvqFzo 6TmBZ1bjp2MXZqQw2d5YXJNb0Vtr9qgV1EqnoG7Lf5q5wcENYAJDVeOzOMxUnM3u2VYbt8GM u3QITxpHw4lOukzarmEmAq3EwwzBxFKKmD9gvAbkAGmimONRiQSY9OBEW4XLmOqy9b7pnoS+ 6x0Oqv8lELvz9TJ2Kh5urXJ/7LOvof9z3R0g7Hn7AWn1Y+0hUKN1vRqziJdIFqZ7kcViiKYA KfYiDPlHSAVguc3qvok0P8A3uS5qvkz2yC3C5Jt913FoNVu3ny0/UCDjpSAqC3qTXMx3otwL DLv/dwARAQABwsF8BBgBAgAmAhsMFiEE5QrdnbBX9Ppk4bbPcTtf4pwUXUUFAmS/xAgFCRew hQYACgkQcTtf4pwUXUWm3Q/8CffJnIqGNBkHHbTE9lVEHYCe0Kq/RTYPv9hpzWmkBqusflBp yZ3IHXdrmlYTd8BX2dZ7UDUz6eZApWoL7R44h+AHIi+pGCe1RFrE8bOI8mQCiLpV+FzwyCe4 dmrdKwFeqfyOIcAZeuXj9a0p3M48A6jN63TK4wImOUQiLHtVMtnEQWFdd/p+Zags9XQ/r417 /gRmLQL8nMrGJVWfnnEMmRGcW2Pmi3yTqHQc8mEe+PJMHp5Po7mv2NXv29YDACtWjdydzY07 4ERRFGNj6JbODc4CbryIgC7lkIAUGUXQoAnEei+rhUtVR0ZR0WCN+IMOAxfdUWYXlOH6X7Sn cB/mA+JtLCp99ongTewiNwVOWT7QDuNX53e6MoCGTzTSJmNIeof6g4hW1iPC3yXTv4p3n0R/ ZjTf6sp+6a0wEm4FUK9gIEQx1qulsSFVqBEU1u5P5PYrMq4QAkpk/DzwkfF3xWpj7o7seNRo eJMnJNUeOnz5R3vMX0lJDbfp+hu+bRyFtjJoWqyaN5SZAieOaMxUkc4I8tLiGKG1gRXs81/d 6TrOqX2RA/kCkpcxDSNck4hY20CrCm/3KwjPsHwsxUDwQQle+MMM41hPIdhxoLwSFE/kkQiT /WrWkF5eTU+WypRO9cvg4m46E/ql0AHEFsZ8HPg55eG23av7Xw/8rRLfJGg= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3038.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/6/24 09:23, Evgeny Karpov wrote: > Thursday, June 6, 2024 1:42 AM > Jonathan Yong <10walls@gmail.com> wrote: >> >> Where is HAVE_64BIT_POINTERS used? >> > > Sorry, it was missed in the posted changes for review. > > Regards, > Evgeny > > diff --git a/gcc/config/mingw/mingw32.h b/gcc/config/mingw/mingw32.h > index 8a6f0e8e8a5..0c9d5424942 100644 > --- a/gcc/config/mingw/mingw32.h > +++ b/gcc/config/mingw/mingw32.h > @@ -82,7 +82,7 @@ along with GCC; see the file COPYING3. If not see > #endif > > #undef SUB_LINK_ENTRY > -#if TARGET_64BIT_DEFAULT || defined (TARGET_AARCH64_MS_ABI) > +#if HAVE_64BIT_POINTERS > #define SUB_LINK_ENTRY SUB_LINK_ENTRY64 > #else > #define SUB_LINK_ENTRY SUB_LINK_ENTRY32 > Looks OK to me.