From: Jeff Law <jeffreyalaw@gmail.com>
To: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Cc: dj@delorie.com
Subject: Re: [PATCH] Remove dbx.h, do not set PREFERRED_DEBUGGING_TYPE from dbxcoff.h, lynx.h
Date: Thu, 9 Sep 2021 09:26:46 -0600 [thread overview]
Message-ID: <edcf6657-8170-0404-0c51-d80717c4b7be@gmail.com> (raw)
In-Reply-To: <49oqn7p0-n811-366q-p55q-1s9pq9ss8n3@fhfr.qr>
On 9/9/2021 7:19 AM, Richard Biener via Gcc-patches wrote:
> The following removes the unused config/dbx.h file and removes the
> setting of PREFERRED_DEBUGGING_TYPE from dbxcoff.h which is
> overridden by all users (djgpp/mingw/cygwin) via either including
> config/i386/djgpp.h or config/i386/cygming.h
>
> There are still circumstances where mingw and cygwin default to
> STABS, namely when HAVE_GAS_PE_SECREL32_RELOC is not defined and
> the target defaults to 32bit code generation.
>
> The new style handling DBX_DEBUGGING_INFO is in line with
> dbxelf.h which does not define PREFERRED_DEBUGGING_TYPE either.
>
> The patch also removes the PREFERRED_DEBUGGING_TYPE define from
> lynx.h which always follows elfos.h already defaulting to DWARF,
> so the comment about STABS being the default is misleading and
> outdated. There's no listed maintainer for Lynx OS.
>
> I have not tested this in any ways but I also have no idea how
> to meaningfully do so.
>
> OK?
>
> Thanks,
> Richard.
>
> 2021-09-09 Richard Biener <rguenther@suse.de>
>
> PR target/102255
> * config/dbx.h: Remove.
> * config/dbxcoff.h: Do not define PREFERRED_DEBUGGING_TYPE.
> * config/lynx.h: Likewise.
I'd go ahead and install. We're on a clear path to kill dbx/stabs and
if this breaks those ports, better to do so as early as possible to give
folks a chance to fix 'em.
I can't really help on the testing side for this -- my tester doesn't
try to test djgpp, mingw or cygwin.
jeff
ps. I'd hazard a guess that lynx.h is for the old lynxos system from
the 90s. I'd be amazed if it's still used in any way.
next prev parent reply other threads:[~2021-09-09 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 13:19 Richard Biener
2021-09-09 14:25 ` Jonathan Yong
2021-09-09 15:26 ` Jeff Law [this message]
2021-09-10 6:02 ` Richard Biener
2021-09-13 3:51 ` Jan-Benedict Glaw
2021-09-13 9:28 ` Richard Biener
2021-09-09 16:11 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edcf6657-8170-0404-0c51-d80717c4b7be@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=dj@delorie.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).