From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by sourceware.org (Postfix) with ESMTPS id E6E7F3858C2C for ; Thu, 9 Sep 2021 15:26:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E6E7F3858C2C Received: by mail-qt1-x82a.google.com with SMTP id l24so1737424qtj.4 for ; Thu, 09 Sep 2021 08:26:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=NyVEm5RQtsEViFcO474ddH7LDlKwYhe7M6I01xjuf6k=; b=eKQKTW3PoehCVDO5Nn+m/Uf/D8ebiYU7PXGGHt7aGKK/Pju1MlaEqCWVsbKagVl5qk GAMRmrn91APHjtBGrk4etZXE4P9SN2Sb/BGnng0MpcTQclcDNid9seJ1WY3YOVsVL8Fb njlS2k2UtKwSslg45Dg5ZyB5wyIxPGFqnAuqLamK0bm62MgUld+DcQZdNUhaccneznLN XeCytCfVOCEfCfSiwreik1MPmSSKiqUomC3vfxQWDrgbHM5oy5EfUbtj0a+etcGjJSXV BKDIVljtjgpx56EXqBA+qhz0biWfNZRHy5bqdraLyHR92JUWInz9CwIpYI6d4SpqGj45 VFcQ== X-Gm-Message-State: AOAM532MZbB6Nj29Zr5qIKRI9BmDbhGjlegn1BoEstdJluG2LBVkiM43 ZOvYG9ie4ovcqW87gCJERa0= X-Google-Smtp-Source: ABdhPJzA83x6J+WxaMiobyX7AfDBLa017pCJ2tUAt9DVOomiFm7PgSk0ylppgmDc+njcGMhI/8TmDQ== X-Received: by 2002:a05:622a:2d0:: with SMTP id a16mr3311690qtx.402.1631201210435; Thu, 09 Sep 2021 08:26:50 -0700 (PDT) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id 187sm1566749qke.32.2021.09.09.08.26.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Sep 2021 08:26:50 -0700 (PDT) Subject: Re: [PATCH] Remove dbx.h, do not set PREFERRED_DEBUGGING_TYPE from dbxcoff.h, lynx.h To: Richard Biener , gcc-patches@gcc.gnu.org Cc: dj@delorie.com References: <49oqn7p0-n811-366q-p55q-1s9pq9ss8n3@fhfr.qr> From: Jeff Law Message-ID: Date: Thu, 9 Sep 2021 09:26:46 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <49oqn7p0-n811-366q-p55q-1s9pq9ss8n3@fhfr.qr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2021 15:26:52 -0000 On 9/9/2021 7:19 AM, Richard Biener via Gcc-patches wrote: > The following removes the unused config/dbx.h file and removes the > setting of PREFERRED_DEBUGGING_TYPE from dbxcoff.h which is > overridden by all users (djgpp/mingw/cygwin) via either including > config/i386/djgpp.h or config/i386/cygming.h > > There are still circumstances where mingw and cygwin default to > STABS, namely when HAVE_GAS_PE_SECREL32_RELOC is not defined and > the target defaults to 32bit code generation. > > The new style handling DBX_DEBUGGING_INFO is in line with > dbxelf.h which does not define PREFERRED_DEBUGGING_TYPE either. > > The patch also removes the PREFERRED_DEBUGGING_TYPE define from > lynx.h which always follows elfos.h already defaulting to DWARF, > so the comment about STABS being the default is misleading and > outdated. There's no listed maintainer for Lynx OS. > > I have not tested this in any ways but I also have no idea how > to meaningfully do so. > > OK? > > Thanks, > Richard. > > 2021-09-09 Richard Biener > > PR target/102255 > * config/dbx.h: Remove. > * config/dbxcoff.h: Do not define PREFERRED_DEBUGGING_TYPE. > * config/lynx.h: Likewise. I'd go ahead and install.  We're on a clear path to kill dbx/stabs and if this breaks those ports, better to do so as early as possible to give folks a chance to fix 'em. I can't really help on the testing side for this -- my tester doesn't try to test djgpp, mingw or cygwin. jeff ps.  I'd hazard a guess that lynx.h is for the old lynxos system from the 90s.  I'd be amazed if it's still used in any way.