From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100480 invoked by alias); 11 Sep 2019 09:30:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 100442 invoked by uid 89); 11 Sep 2019 09:30:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=H*c:alternative X-HELO: esa1.mentor.iphmx.com Received: from esa1.mentor.iphmx.com (HELO esa1.mentor.iphmx.com) (68.232.129.153) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Sep 2019 09:30:37 +0000 IronPort-SDR: f8osKFnm3Id68VEGpZn+DmueB7WM/MlwGW7laZ0A+q5pJO7o2qwb/i9WNrybAzbkbLAb/w4wdh 67L+YV7ktuRu6l+6UC4MhF26rhDj5Ogte6y2iaUumDs/NZ4GvcuWEpTfaKoGibRprrjhDO/yyJ stpbjSYRKydn4lxVNxbxMMlin2kJP67c94WAsb2YP1Oid0N8eDtR0u83xIuTb2uxjIrj+wF7kJ Zi5xUwBw91EnoawXN2rcmSM6Nea+mRTfSQt09kxINgIdd72FqLAfyHgVpe2ipEx+3qC2RMKgS3 hYM= Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 11 Sep 2019 01:30:34 -0800 IronPort-SDR: 9k3FCjFcb4zaqj4elsony5uhEVukYyGpac73vkBUjLP0hxnmaacz1C5ipuYv4+jUmy6ULAdoEq dPdnaQPhdeRfQvQFWouXOAt/ldRslLbkTIOR7DBp7dO3x6QsKxcx65OY2FEQFGPn6OC8kI0zrZ rnfkzfCU+KV+q7Z8ite8+8qM/OAY10bzY7+NaabJoYYlSJYSi1Nsx9bTJdLxYWR/QcrQaXbCgi W2r7lG3jZ+dIx9opVvwBGXc0tBNAEACZeZddeImp7DqRXQfbI2SOqGnRvPKEr2NZG1Pegi+qTZ g7Y= To: , Jakub Jelinek From: Tobias Burnus Subject: [patch, libgomp] Fix segfault with plugin-hsa Message-ID: Date: Wed, 11 Sep 2019 09:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Return-Path: tobias@codesourcery.com Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2019-09/txt/msg00718.txt.bz2 Hi all, hi Jakub, when playing around with offloading, I got an hsa initialization error (/dev/... lacked write permission) and the library call returned with an error status – but hsa_fns.hsa_status_string_fn didn't set the message to the string variable. Hence, the string variable was uninitialized and libgomp crashed when printing the error message; "[unknown]" is not the best HSA run-time message, but at least the primary message is shown and there is no crash :-) Build and tested on x86_64-gnu-linux. OK for the trunk and GCC 9? Tobias 2019-09-11 Tobias Burnus * plugin/plugin-hsa.c (hsa_warn, hsa_fatal, hsa_error): Ensure string is initialized. diff --git a/libgomp/plugin/plugin-hsa.c b/libgomp/plugin/plugin-hsa.c index 80f23f9beb6..c0837d04e5d 100644 --- a/libgomp/plugin/plugin-hsa.c +++ b/libgomp/plugin/plugin-hsa.c @@ -289,7 +289,7 @@ hsa_warn (const char *str, hsa_status_t status) if (!debug) return; - const char *hsa_error_msg; + const char *hsa_error_msg = "[unknown]"; hsa_fns.hsa_status_string_fn (status, &hsa_error_msg); fprintf (stderr, "HSA warning: %s\nRuntime message: %s", str, hsa_error_msg); @@ -301,7 +301,7 @@ hsa_warn (const char *str, hsa_status_t status) static void hsa_fatal (const char *str, hsa_status_t status) { - const char *hsa_error_msg; + const char *hsa_error_msg = "[unknown]"; hsa_fns.hsa_status_string_fn (status, &hsa_error_msg); GOMP_PLUGIN_fatal ("HSA fatal error: %s\nRuntime message: %s", str, hsa_error_msg); @@ -313,7 +313,7 @@ hsa_fatal (const char *str, hsa_status_t status) static bool hsa_error (const char *str, hsa_status_t status) { - const char *hsa_error_msg; + const char *hsa_error_msg = "[unknown]"; hsa_fns.hsa_status_string_fn (status, &hsa_error_msg); GOMP_PLUGIN_error ("HSA fatal error: %s\nRuntime message: %s", str, hsa_error_msg);