From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
To: Michael Matz <matz@suse.de>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
Alexander Monakov <amonakov@ispras.ru>,
Gerald Pfeifer <gerald@pfeifer.com>,
gcc-patches@gcc.gnu.org, GCC Development <gcc@gcc.gnu.org>
Subject: Re: [PATCH, v3] wwwdocs: e-mail subject lines for contributions
Date: Mon, 03 Feb 2020 17:54:00 -0000 [thread overview]
Message-ID: <ee2626e0-a56a-9ff0-6c3f-0fdc97dbfbea@arm.com> (raw)
In-Reply-To: <alpine.LSU.2.21.2002031741040.12763@wotan.suse.de>
On 03/02/2020 17:48, Michael Matz wrote:
> Hi,
>
> On Mon, 3 Feb 2020, Richard Earnshaw (lists) wrote:
>
>> The idea is that the [...] part is NOT part of the commit, only part of
>> the email.
>
> I understand that, but the subject line of this thread says "e-mail
> subject lines", so I thought we were talking about, well, exactly that;
> and I see no value of these tags in e-mails either.
>
> (They might have a low but non-zero value for projects that use
> a single mailing list for patches and generic discussion, but we are not
> such project)
>
> Basically: if they are deemed to clutter the git log for whatever reason,
> then there must be a very good argument for why they not also clutter
> e-mail subject lines, but instead are essential to have there,
> but not in the log.
>
Well, I'd review a patch differently depending on whether or not it was
already committed, a patch requiring review or an RFC looking for more
general comments, so I *do* think such an email prefix is useful.
>> 'git am' would strip leading [...] automatically unless
>> you've configured, or asked git to do otherwise. So that leading part
>> is not counted for the length calculation.
>
> There's still e-mail netiquette which also should be obeyed, or at least
> not contradicted by git netiquette.
>
The 50 char limit seems to come from wanting git log --oneline to not
wrap in an 80 column terminal. Whilst laudable, I'm not sure that such
a limit doesn't become too restrictive and then lead to
hard-to-understand summaries.
R.
next prev parent reply other threads:[~2020-02-03 17:54 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 10:43 [wwwdocs] Updates to contribute.html for git-friendly posting rules Richard Earnshaw (lists)
2020-01-19 14:47 ` Gerald Pfeifer
2020-01-20 11:54 ` Richard Earnshaw (lists)
2020-01-21 15:04 ` [PATCH, v2] wwwdocs: e-mail subject lines for contributions Richard Earnshaw (lists)
2020-01-21 15:10 ` Jakub Jelinek
2020-01-21 15:34 ` Richard Earnshaw (lists)
2020-01-21 16:26 ` Jakub Jelinek
2020-01-21 16:26 ` Richard Earnshaw (lists)
2020-01-21 18:32 ` Jason Merrill
2020-01-21 19:09 ` Richard Earnshaw (lists)
2020-01-22 9:35 ` Jakub Jelinek
2020-01-22 10:00 ` Richard Earnshaw (lists)
2020-01-22 10:04 ` Jakub Jelinek
2020-01-22 16:27 ` Richard Sandiford
2020-01-22 17:02 ` Marek Polacek
2020-01-22 17:10 ` Richard Earnshaw (lists)
2020-01-21 20:17 ` Segher Boessenkool
2020-01-22 10:14 ` Richard Earnshaw (lists)
2020-01-22 14:06 ` Segher Boessenkool
2020-01-22 19:15 ` [PATCH, v3] " Richard Earnshaw (lists)
2020-02-03 11:41 ` Richard Earnshaw (lists)
2020-02-03 11:54 ` Alexander Monakov
2020-02-03 11:59 ` Richard Earnshaw (lists)
2020-02-03 12:51 ` Alexander Monakov
2020-02-03 14:11 ` Jason Merrill
2020-02-03 15:13 ` Richard Earnshaw (lists)
2020-02-03 15:15 ` Richard Earnshaw (lists)
2020-02-03 13:54 ` Segher Boessenkool
2020-02-03 14:00 ` Richard Earnshaw (lists)
2020-02-03 14:13 ` Jonathan Wakely
2020-02-03 15:05 ` Richard Earnshaw (lists)
2020-02-03 16:12 ` Andrew Clayton
2020-02-03 17:17 ` Segher Boessenkool
2020-02-03 17:19 ` Segher Boessenkool
2020-02-03 17:31 ` Michael Matz
2020-02-03 17:36 ` Richard Earnshaw (lists)
2020-02-03 17:49 ` Michael Matz
2020-02-03 17:54 ` Jakub Jelinek
2020-02-03 18:09 ` Michael Matz
2020-02-04 10:41 ` Andrew Stubbs
2020-02-03 18:57 ` Segher Boessenkool
2020-02-03 17:54 ` Richard Earnshaw (lists) [this message]
2020-02-03 18:20 ` Michael Matz
2020-02-03 19:48 ` Segher Boessenkool
2020-02-03 18:03 ` Joseph Myers
2020-02-03 17:34 ` Segher Boessenkool
2020-02-27 13:38 ` Nathan Sidwell
2020-03-02 13:01 ` Richard Earnshaw (lists)
2020-03-02 13:35 ` Segher Boessenkool
2020-03-02 14:31 ` Nathan Sidwell
2020-03-02 14:41 ` Jonathan Wakely
2020-03-02 15:22 ` Richard Earnshaw (lists)
2020-02-03 15:34 ` [wwwdocs] Updates to contribute.html for git-friendly posting rules Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee2626e0-a56a-9ff0-6c3f-0fdc97dbfbea@arm.com \
--to=richard.earnshaw@arm.com \
--cc=amonakov@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=matz@suse.de \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).