From: Andrew Stubbs <ams@codesourcery.com>
To: Tobias Burnus <tobias@codesourcery.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Jakub Jelinek <jakub@redhat.com>
Subject: Re: [Patch] libgomp/gcn: Prepare for reverse-offload callback handling
Date: Fri, 18 Nov 2022 17:56:04 +0000 [thread overview]
Message-ID: <ee36650e-5920-fceb-b62d-3565871779ec@codesourcery.com> (raw)
In-Reply-To: <e3246480-ae8c-433d-f4e5-0e456ac6cc67@codesourcery.com>
On 18/11/2022 17:41, Tobias Burnus wrote:
> Attached is the updated/rediffed version, which now uses the builtin
> instead of the 'asm("s8").
>
> The code in principle works; that is: If no private stack variables are
> copied, it works.
>
> Or in other words: reverse-offload target regions that don't use
> firstprivate or mapping work, the rest would crash. That's avoided by
> not accepting reverse offload inside GOMP_OFFLOAD_get_num_devices for now.
>
> To get it working, the manual stack allocation patch + the trivial
> update to that get_num_devices func is needed, but no change to the
> attached patch.
>
> In order to reduce local patches, I would love to have it on mainline –
> otherwise, I have at least the current version in gcc-patches@.
OK with me.
Andrew
next prev parent reply other threads:[~2022-11-18 17:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 13:15 Tobias Burnus
2022-09-27 13:16 ` Tobias Burnus
2022-09-29 16:24 ` Andrew Stubbs
2022-10-12 14:29 ` Tobias Burnus
2022-10-12 17:09 ` Andrew Stubbs
2022-10-12 17:25 ` Tobias Burnus
2022-11-18 17:41 ` Tobias Burnus
2022-11-18 17:56 ` Andrew Stubbs [this message]
2022-11-21 13:40 ` [Patch] libgomp/gcn: fix/improve struct output (was: [Patch] libgomp/gcn: Prepare for reverse-offload callback handling) Tobias Burnus
2022-11-21 14:19 ` Andrew Stubbs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee36650e-5920-fceb-b62d-3565871779ec@codesourcery.com \
--to=ams@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).