From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][committed] aarch64: Suggest an -mcpu option when user passes CPU name to -march
Date: Mon, 5 Sep 2022 14:42:52 +0100 [thread overview]
Message-ID: <ee4321d2-bba6-aaac-e1d3-a95a7c0a546f@foss.arm.com> (raw)
In-Reply-To: <PAXPR08MB6926B8B36C90DA7103DB111D937F9@PAXPR08MB6926.eurprd08.prod.outlook.com>
On 05/09/2022 14:35, Kyrylo Tkachov via Gcc-patches wrote:
> Hi all,
>
> This small patch helps users who confuse -march and -mcpu on AArch64.
> Sometimes users pass -march with a CPU name, where they most likely wanted to
> use -mcpu, which would select the right architecture features *and* tune for
> their desired CPU. Currently we'll just error out with an unkown architecture
> message and list the valid architecture options.
> With this patch we check if their string matches a known CPU and suggest they
> use an -mcpu option instead.
>
> So compiling with -march=neoverse-n1 will now give the error:
> cc1: error: unknown value 'neoverse-n1' for '-march'
> cc1: note: valid arguments are: armv8-a armv8.1-a armv8.2-a armv8.3-a armv8.4-a armv8.5-a armv8.6-a armv8.7-a armv8.8-a armv8-r armv9-a
> cc1: note: did you mean '-mcpu=neoverse-n1'?
>
> Bootstrapped and tested on aarch64-none-linux-gnu.
> Pushing to trunk.
> Thanks,
> Kyrill
>
> gcc/ChangeLog:
>
> * config/aarch64/aarch64.cc (aarch64_validate_march): Check if invalid arch
> string is a valid -mcpu string and emit hint.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/aarch64/spellcheck_10.c: New test.
What about the reverse case, passing an architecture to -mcpu?
R.
next prev parent reply other threads:[~2022-09-05 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 13:35 Kyrylo Tkachov
2022-09-05 13:42 ` Richard Earnshaw [this message]
2022-09-06 9:53 ` Kyrylo Tkachov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee4321d2-bba6-aaac-e1d3-a95a7c0a546f@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).