From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 17CF63858C3A for ; Mon, 14 Aug 2023 17:58:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17CF63858C3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692035923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u243UZqC4KcR7z5RI7UtlJzX1DzdjheWwh0yLAA17dY=; b=Mdxdms0W3co2gmHQmveEPZnVyw1xWI5K1cLKagqVukh2d1bsKtituK6njRQisOpQuoQeq9 8k2jbU/PRYiKsZZq6RZBiTff+YwRhBHINQmXaow8GEBU1BpvdRWuHxfQwMTpECPlIdofbi W+TD0w80ZIfY9qOJVhNVUREB2GJuVU4= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-gtAcLg8UM3S-vC5mo02D1Q-1; Mon, 14 Aug 2023 13:58:42 -0400 X-MC-Unique: gtAcLg8UM3S-vC5mo02D1Q-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6468e19af74so28804236d6.0 for ; Mon, 14 Aug 2023 10:58:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692035922; x=1692640722; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u243UZqC4KcR7z5RI7UtlJzX1DzdjheWwh0yLAA17dY=; b=PsIhFs6XG0ZOSMwSXlHrh4ozsdLx5qM+pveLsqrtqbl1E5WPQp+qVbSRgT11m1bGOM pD0O7W+oQJCQ8wREJ4O/SqkCCk7UOAzAkGg9SLABUurCf3liYgSRlLxVDotkRP2pT1Et 6EJNui1zOsSlSTfy6/93Ng+5cyJZG3srYjxwlnJUYdhXGF5YF4YLaEg294k821SdaO3D 22x9RauILWZoFFEUSx1l6U93bp3VqWxI7MT5jHvo/QeWQ7KAgvUXL8VtQx+WmjlUZIcD wAXtnib9FBgCVM7MHwEsQgOm2FnD+eJRDuqWUYcmFLtK2xAdeShNIxOXyMKGE37w0vvj wnkQ== X-Gm-Message-State: AOJu0YxMDyoqzJRHYsQZDCGy/JvqfM6+mbackhiShABw9xchfhRWfgvd gWznd5FPXbwJ6Z5Cw6xw2nvmPO5UhgtTEk8Q+g78q8fKSeciCPZVeAAOF6BIWS9qc/APRdz0oRs 3s1HvqOccYLL76K/LtA== X-Received: by 2002:a0c:de09:0:b0:63c:f1d3:f662 with SMTP id t9-20020a0cde09000000b0063cf1d3f662mr11127724qvk.0.1692035922109; Mon, 14 Aug 2023 10:58:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHo4b0kBO5SVwNmaMwSx9F5JyH9QGwcq4tOOqAAeIW1/vkFr5BabxooKZVQSw/eHlZwsF1enA== X-Received: by 2002:a0c:de09:0:b0:63c:f1d3:f662 with SMTP id t9-20020a0cde09000000b0063cf1d3f662mr11127706qvk.0.1692035921799; Mon, 14 Aug 2023 10:58:41 -0700 (PDT) Received: from [192.168.1.104] (121.56.59.66.in-addr.crocker.net. [66.59.56.121]) by smtp.gmail.com with ESMTPSA id d19-20020a0ce453000000b006238b37fb05sm3537566qvm.119.2023.08.14.10.58.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Aug 2023 10:58:41 -0700 (PDT) Message-ID: Date: Mon, 14 Aug 2023 13:58:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v1] c++: follow DR 2386 and update implementation of get_tuple_size [PR110216] To: gnaggnoyil , gcc-patches@gcc.gnu.org References: <20230812081652.1851216-1-gnaggnoyil@gmail.com> From: Jason Merrill In-Reply-To: <20230812081652.1851216-1-gnaggnoyil@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/12/23 04:16, gnaggnoyil wrote: > DR 2386 updated the tuple_size requirements for structured binding and > it now requires tuple_size to be considered only if > std::tuple_size names a complete class type with member value. GCC > before this patch does not follow the updated requrements, and this > patch is intended to implement it. > > DR 2386 > PR c++/110216 > > gcc/cp/ChangeLog: > > * decl.cc (get_tuple_size): Update implemetation to follow DR 2386. > > gcc/testsuite/ChangeLog: > > * g++.dg/cpp1z/decomp10.C: Update expected error message for DR 2386. > * g++.dg/cpp1z/pr110216.C: New test. > > Signed-off-by: gnaggnoyil Pushed, thanks! Note that the GCC DCO policy (https://gcc.gnu.org/dco.html) requires real names in the sign-off; in this case I've applied the patch anyway because it is small enough that it's not legally significant for copyright. I think if you want to contribute larger patches under this pseudonym, you should file a copyright assignment with the FSF, which explicitly allows this. "If a contributor wants the FSF to publish only a pseudonym, that is ok. The contributor should say this, and state the desired pseudonym, when answering the request- form. The actual legal papers will use the real name, but the FSF will publish only the pseudonym."[2] Thanks again, Jason [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/Documentation/process?id=d4563201f33a022fc0353033d9dfeb1606a88330 [2] https://www.gnu.org/prep/maintain/maintain.html#Copyright-Papers