From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72916 invoked by alias); 13 Feb 2020 09:23:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 72828 invoked by uid 89); 13 Feb 2020 09:23:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Feb 2020 09:23:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581585793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pfd2tWDDpQqeeqiMdJR5BvbtFGQWnq4ZQQD8hAoMnow=; b=ZE+AZv+zbQLWK2d8wLqiVHM2A05sbhC9HMTEmmUVvWHi6jkeTekwPAzOFDQO59cx4Vca4G Q+gyU/iPtVCmxCcMTuOkIiwSr7N1KtgqP0KpgbftI2/LkefyDEjixOp8sLDer0sjvajtOa 372LkP5UKBnlXf9K25tQwMmsI38ge+I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-OyBMUFKHMKOEfKn6tTFTUA-1; Thu, 13 Feb 2020 04:23:11 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4AAE107ACCD for ; Thu, 13 Feb 2020 09:23:10 +0000 (UTC) Received: from ovpn-116-56.phx2.redhat.com (ovpn-116-56.phx2.redhat.com [10.3.116.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3CACA90093; Thu, 13 Feb 2020 09:23:10 +0000 (UTC) Message-ID: Subject: Re: testsuite: Fix g++.dg/analyzer/pr93212.C with check-c++-all From: David Malcolm To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Date: Thu, 13 Feb 2020 09:23:00 -0000 In-Reply-To: <20200213071108.GC17695@tucnak> References: <20200206202730.18584-1-dmalcolm@redhat.com> <20200213071108.GC17695@tucnak> User-Agent: Evolution 3.32.5 (3.32.5-1.fc30) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00778.txt.bz2 On Thu, 2020-02-13 at 08:11 +0100, Jakub Jelinek wrote: > On Thu, Feb 06, 2020 at 03:27:29PM -0500, David Malcolm wrote: > > gcc/testsuite/ChangeLog: > > PR analyzer/93212 > > * g++.dg/analyzer/analyzer.exp: New subdirectory and .exp > > suite. > > * g++.dg/analyzer/malloc.C: New test. > > * g++.dg/analyzer/pr93212.C: New test. > > The test FAILs with c++11: > .../gcc/testsuite/g++.dg/analyzer/pr93212.C:4:1: error: 'lol' > function uses 'auto' type specifier without trailing return type > .../gcc/testsuite/g++.dg/analyzer/pr93212.C:4:1: note: deduced return > type only available with '-std=c++14' or '-std=gnu++14' > > Fixed thusly, regtested on x86_64-linux, committed to trunk as > obvious. Thanks Jakub, and sorry for the failure. I did some digging into why this got through my testing. My standard patch testing involves a bootstrap build with these three Makefile targets in sequence: make all make install make check each teed to a logfile, and with a suitable -j I hadn't noticed the check-c++-all in cp/Make-lang.in. I've been using "--target_board=unix\{-m32,-m64\}" in my RUNTESTFLAGS during development of a patch, but I notice now that I didn't have it in my bootstrap testing. I've fixed that, and added check-c++-all. Are there any other Makefile targets I should be testing with? Thanks Dave