From: Jeff Law <jeffreyalaw@gmail.com>
To: Richard Sandiford <richard.sandiford@arm.com>,
jlaw@ventanamicro.com, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/6] rtl-ssa: Create REG_UNUSED notes after all pending changes
Date: Tue, 24 Oct 2023 11:22:43 -0600 [thread overview]
Message-ID: <ee9701b3-a5f0-4b3d-b3b6-8ecfb62ea34c@gmail.com> (raw)
In-Reply-To: <20231024105006.3337671-3-richard.sandiford@arm.com>
On 10/24/23 04:50, Richard Sandiford wrote:
> Unlike REG_DEAD notes, REG_UNUSED notes need to be kept free of
> false positives by all passes. function_info::change_insns
> does this by removing all REG_UNUSED notes, and then using
> add_reg_unused_notes to add notes back (or create new ones)
> where appropriate.
>
> The problem was that it called add_reg_unused_notes on the fly
> while updating each instruction, which meant that the information
> for later instructions in the change set wasn't up to date.
> This patch does it in a separate loop instead.
>
> gcc/
> * rtl-ssa/changes.cc (function_info::apply_changes_to_insn): Remove
> call to add_reg_unused_notes and instead...
> (function_info::change_insns): ...use a separate loop here.
OK
jeff
next prev parent reply other threads:[~2023-10-24 17:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 10:50 [PATCH 0/6] rtl-ssa: Various fixes needed for the late-combine pass Richard Sandiford
2023-10-24 10:50 ` [PATCH 1/6] rtl-ssa: Ensure global registers are live on exit Richard Sandiford
2023-10-24 17:21 ` Jeff Law
2023-10-24 10:50 ` [PATCH 2/6] rtl-ssa: Create REG_UNUSED notes after all pending changes Richard Sandiford
2023-10-24 17:22 ` Jeff Law [this message]
2023-10-24 10:50 ` [PATCH 3/6] rtl-ssa: Fix ICE when deleting memory clobbers Richard Sandiford
2023-10-24 17:24 ` Jeff Law
2023-10-24 10:50 ` [PATCH 4/6] rtl-ssa: Handle artifical uses of deleted defs Richard Sandiford
2023-10-24 17:26 ` Jeff Law
2023-10-24 10:50 ` [PATCH 5/6] rtl-ssa: Calculate dominance frontiers for the exit block Richard Sandiford
2023-10-24 17:28 ` Jeff Law
2023-10-24 10:50 ` [PATCH 6/6] rtl-ssa: Handle call clobbers in more places Richard Sandiford
2023-10-24 17:37 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee9701b3-a5f0-4b3d-b3b6-8ecfb62ea34c@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jlaw@ventanamicro.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).