From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17485 invoked by alias); 9 Jul 2019 02:28:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 17476 invoked by uid 89); 9 Jul 2019 02:28:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,MIME_CHARSET_FARAWAY,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1577 X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Jul 2019 02:28:18 +0000 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x692RHMe150641 for ; Mon, 8 Jul 2019 22:28:16 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2tmf1dn8c8-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 08 Jul 2019 22:28:16 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 9 Jul 2019 03:28:14 +0100 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 9 Jul 2019 03:28:12 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x692RxDN34341256 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 Jul 2019 02:27:59 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D12CAA4055; Tue, 9 Jul 2019 02:28:11 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5A1EFA4040; Tue, 9 Jul 2019 02:28:10 +0000 (GMT) Received: from kewenlins-mbp.cn.ibm.com (unknown [9.200.146.20]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 9 Jul 2019 02:28:10 +0000 (GMT) Subject: Re: [PATCH V4] PR88497 - Extend reassoc for vector bit_field_ref To: Segher Boessenkool Cc: Richard Biener , GCC Patches , Bill Schmidt References: <8d92a6c9-e338-e662-9eec-ef3059faba71@linux.ibm.com> <23b4209c-2c15-a9c3-1322-023f75a67e0c@linux.ibm.com> <20190708163244.GE30355@gate.crashing.org> From: "Kewen.Lin" Date: Tue, 09 Jul 2019 02:37:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190708163244.GE30355@gate.crashing.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit x-cbid: 19070902-0008-0000-0000-000002FB1BC6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19070902-0009-0000-0000-0000226879E6 Message-Id: X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00632.txt.bz2 Hi Segher, on 2019/7/9 ÉÏÎç12:32, Segher Boessenkool wrote: > Hi Kewen, > > On Mon, Jul 08, 2019 at 04:07:00PM +0800, Kewen.Lin wrote: >> gcc/ChangeLog > > (You have trailing spaces in the changelog, fwiw). > Thanks for catching! >> --- /dev/null >> +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr88497-1.c >> @@ -0,0 +1,60 @@ >> +/* { dg-do run } */ >> +/* { dg-require-effective-target vect_double } */ >> +/* { dg-require-effective-target powerpc_vsx_ok { target { powerpc*-*-* } } } */ > > For "dg-do run" tests, you need "powerpc_vsx_hw". "_ok" only tests if > the assembler can handle VSX instructions, not whether the test system > can run them. (powerpc_vsx_ok is what you need for "dg-do assemble" or > "dg-do link" tests. It also tests if you can use -mvsx, but that doesn't > do what you might hope it does: you can use -mvsx together with a -mcpu= > that doesn't support VSX, for example). > Thanks, I will update it. But sorry that I can't find "powerpc_vsx_hw" but "vsx_hw_available". I guess it's the one you are referring to? And I happened to find the vect_double will force powerpc to check vsx_hw_available. This reminds me I should use sse2 instead of sse2-runtime for case 2-5. >> +++ b/gcc/testsuite/gcc.dg/tree-ssa/pr88497-2.c >> @@ -0,0 +1,37 @@ >> +/* { dg-do compile } */ >> +/* { dg-require-effective-target vect_float } */ >> +/* { dg-require-effective-target powerpc_altivec_ok { target { powerpc*-*-* } } } */ > > This one is fine, and the rest of the tests as well. > > > Segher >