public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: juzhe.zhong@rivai.ai, gcc-patches@gcc.gnu.org
Cc: kito.cheng@gmail.com, palmer@dabbelt.com
Subject: Re: [PATCH] RISC-V: Fix PR109399 VSETVL PASS bug
Date: Tue, 4 Apr 2023 19:26:42 -0600	[thread overview]
Message-ID: <eec0b32a-4b49-646d-0503-1c99c113a3fc@gmail.com> (raw)
In-Reply-To: <20230404084630.48657-1-juzhe.zhong@rivai.ai>



On 4/4/23 02:46, juzhe.zhong@rivai.ai wrote:
> From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
> 
> This patch fix bug:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109399
> 
>          PR 109399
> 
> gcc/ChangeLog:
> 
>          * config/riscv/riscv-vsetvl.cc (pass_vsetvl::compute_local_backward_infos): Update user vsetvl in local demand fusion.
> 
> gcc/testsuite/ChangeLog:
> 
>          * gcc.target/riscv/rvv/vsetvl/pr109399.c: New test.
Thanks.  Installed.

I noted that change_vsetvl_insn does not have a function comment.  Can 
you please add one.  Perhaps something like this:

/* INSN is either a vector configuration insn, or an insn with a vtype
    that is immediately preceded by a vector configuration insn.  In
    both cases, change the vector configuration insn to utilize the
    vector configuration state in INFO.  */


      reply	other threads:[~2023-04-05  1:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04  8:46 juzhe.zhong
2023-04-05  1:26 ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eec0b32a-4b49-646d-0503-1c99c113a3fc@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=juzhe.zhong@rivai.ai \
    --cc=kito.cheng@gmail.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).