From: Jason Merrill <jason@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH RFA] c-family: attribute ((aligned, mode)) [PR100545]
Date: Fri, 29 Apr 2022 15:20:31 -0400 [thread overview]
Message-ID: <eec134b7-8af7-71eb-2b44-34da409a32e5@redhat.com> (raw)
In-Reply-To: <d7d30c65-6fce-6f0f-9ce3-a11a100d58ba@redhat.com>
On 4/27/22 19:48, Jason Merrill wrote:
> On 4/27/22 13:02, Joseph Myers wrote:
>> On Wed, 27 Apr 2022, Jason Merrill via Gcc-patches wrote:
>>
>>> + if (typedef_variant_p (type))
>>> + {
>>> + /* Set up the typedef all over again. */
>>
>> This seems wrong when the typedef is just being used in another
>> declaration with the mode attribute, as opposed to being defined using
>> the
>> mode attribute. E.g. the following test is valid and accepted before the
>> patch, but wrongly rejected after the patch because the typedef has had
>> its type changed.
>>
>> typedef int I;
>> int x;
>> I y __attribute__ ((mode(QI)));
>> extern I x;
>
> Ah, good point. Fixed thus:
Marek pointed out elsewhere that the first testcase should have
// { dg-additional-options -g }
OK for 13 with that change?
next prev parent reply other threads:[~2022-04-29 19:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 15:19 Jason Merrill
2022-04-27 16:58 ` Marek Polacek
2022-04-27 17:02 ` Joseph Myers
2022-04-27 23:48 ` Jason Merrill
2022-04-29 19:20 ` Jason Merrill [this message]
2022-04-29 19:46 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eec134b7-8af7-71eb-2b44-34da409a32e5@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).