From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id E6FCB3858401 for ; Mon, 26 Jun 2023 07:51:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E6FCB3858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2b69ff54321so10324521fa.2 for ; Mon, 26 Jun 2023 00:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687765902; x=1690357902; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ROTPO1OqV2ovqW4jX9USumHJbhwu0vmZzb+cUrTfXIQ=; b=UbayO2KBy8FVkGdOnvm1xHZ2bfafdqaI4mj18Mi5XO9Dimgkh8TEAnobU8wNqbHoDC efs4EL7KxHgCfz/Ck0zsPK9P3A08Lc3BzWIVLL7wJKnzNY4JckgZWov5zb65gq3VUjfA T/Qj0fXsOCRa5XZCr5Bjg6ZiYDipaj5m9DBqnOo/UBroM4F9eH8vRHyfIeSo5tS76hsM JUjPH5DkJzoNLdGqbeqqn5HSSYs56SDXJPgI/skNhEX6ZEEdKSGCRwjJnwpLjiwO0Pq7 ZLC/ghhsUlZ3PejXw2oMP7+6nxo/GhrMrdtmVwf8HKOmPejw0u7TQ82V+iioLcoNNSH1 LRUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687765902; x=1690357902; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ROTPO1OqV2ovqW4jX9USumHJbhwu0vmZzb+cUrTfXIQ=; b=PZs0bkHJ8V3V4ZueAUiwDiY//bBOzgn7c8eyCVzJQVTUXEFr1qVjCTMZsi2JVcUbO2 Rj1G1BidGvCrjTnzP55hAcnxg8OrMsG4DZmThf7jpd8JHu+waBj/jLRcytXYGUX9E00m vyDR/nqxpfRLa8NwKzieTr3EuDiJKpm+EW5yFuCHMNiMVkbIvUcUkeYagTp06psY5Fev sgtg88Zu+SFRVftdwLZeDLdkQ+XIf2zZysiFQglWDcWQcLTS3P9HWb+4NsrXQZ3y00I4 i2VfMm3WbfDt8OXF+4uYjpumJmSAlotUOGMDqujPAmY+VmbYQpdCyjgrxhgwPJUVdjN2 5dZQ== X-Gm-Message-State: AC+VfDwBixiZrvYNBgkJ255+yNqry2fMGQaJMtrXc5gXaliHgHv8io/i 6cUOXovsyATN6kCI9/BVY0k= X-Google-Smtp-Source: ACHHUZ6VzyWROSjeukfcl3eMXk3JzdcDVfDDs4NZUrP+JvUsZHlOEmqYxwSExQdCP132KhXbaKQ6cA== X-Received: by 2002:a05:651c:104:b0:2b5:80dd:5e6d with SMTP id a4-20020a05651c010400b002b580dd5e6dmr8724113ljb.50.1687765902069; Mon, 26 Jun 2023 00:51:42 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id s25-20020aa7c559000000b0051d914a9f49sm1833596edr.65.2023.06.26.00.51.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jun 2023 00:51:41 -0700 (PDT) Message-ID: Date: Mon, 26 Jun 2023 09:51:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Cc: rdapp.gcc@gmail.com, kito.cheng@gmail.com, kito.cheng@sifive.com, palmer@dabbelt.com, palmer@rivosinc.com, jeffreyalaw@gmail.com Subject: Re: [PATCH] RISC-V: Enhance RVV VLA SLP auto-vectorization To: Juzhe-Zhong , gcc-patches@gcc.gnu.org References: <20230626065101.75459-1-juzhe.zhong@rivai.ai> Content-Language: en-US From: Robin Dapp In-Reply-To: <20230626065101.75459-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Juzhe, > Currently, we are able to generate step vector with base == 0: > { 0, 0, 2, 2, 4, 4, ... } > > ASM: > > vid > vand > > However, we do wrong for step vector with base != 0: > { 1, 1, 3, 3, 5, 5, ... } > > Before this patch, such case will run fail. > > After this patch, we are able to pass the testcase and generate the step vector with asm: > > vid > vand > vadd Can't we use the first case as long as pow2_p (base) == true and not just for base == 0? Regards Robin