From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 274C93858D1E for ; Wed, 8 Nov 2023 02:50:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 274C93858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 274C93858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699411827; cv=none; b=cApb6ODTFwrbp2TS5VusB8yhr0uQ+ppOs4TZ8Z2Xn2yYFVMb7T7XL9DU/RLjYUEz8G8Y2miVRPVtJIdcNLhZ5kazH62vnDZzDhdrKaZd91ehIWo+jahk4okOda8SVvfLUidZleT/2nUI/KfrCLmwDtm3mNXvVJknX5jBCuBhp44= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699411827; c=relaxed/simple; bh=5mitKu5hANDkHjC5ho2d7syjaEjW2p6kHyHpdZwu09k=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=B+KTdk34LEqKTGwk38SDwcVKnIoSpX+wo5qBCpHC2rTqR46eUHgbkXOhb+dV2bUpF8oWL87pJlEa02BLtJaB2RuzlLPV3sHCW0LFgkwZuwm3rl6qvCYUq6ldhw2MjT9wSiAdLQOLp9LpRfsvE0bmdxJabDeJn+1vEuNJofHvUBo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A82kIFM013172; Wed, 8 Nov 2023 02:50:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : from : to : cc : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=u21/Cbo5s0hE2FtPjaDhYsjwXbEbdIMYNi97f6tPHdI=; b=n1BSLMFB3nJY2ClyU9cjg4yAhfntUKyWutBKB0+zyWGcorKsj7Ofg+qxWUkbBuAYCbUL PDI2geXPWoPvDYGsfb6kAjVb4urAHrIXNWFfEa5yfV1mhklSBcBE57Alze+zlMJ7otBf g/4b/OUbbzfamT4JTclazLqO0wZxXWbWl/S5FYWf4dzdsfI3Wj4UDCNbg/B86ET8ECOQ JE3uhiSRaZCsngstk1x4tEOwJdCDRwzwod7i5fKCYEHDGACz3hHd4/RavKXSEKTEew+Y lvOUkTvhzH5HCm2AWXsUhJYYrSA1yPpsuivtrEJF8uMaTySE+JNk3CPIWQ2RUEAflQ6y DQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u80wash07-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Nov 2023 02:50:23 +0000 Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3A82l4Fa016426; Wed, 8 Nov 2023 02:50:22 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u80wasgyj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Nov 2023 02:50:22 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3A82HXR5003455; Wed, 8 Nov 2023 02:50:22 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3u7w21swny-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Nov 2023 02:50:21 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3A82oJAr43123354 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Nov 2023 02:50:19 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 284AF20040; Wed, 8 Nov 2023 02:50:19 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ABAAF20043; Wed, 8 Nov 2023 02:50:16 +0000 (GMT) Received: from [9.177.74.45] (unknown [9.177.74.45]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 8 Nov 2023 02:50:16 +0000 (GMT) Message-ID: Date: Wed, 8 Nov 2023 10:50:14 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: PING^6 [PATCH 0/9] rs6000: Rework rs6000_emit_vector_compare Content-Language: en-US From: "Kewen.Lin" To: segher@kernel.crashing.org, dje.gcc@gmail.com Cc: bergner@linux.ibm.com, meissner@linux.ibm.com, gcc-patches@gcc.gnu.org References: <20221124091557.514727-1-linkw@linux.ibm.com> <59fbb646-c855-c4cd-10f9-40996f4e9720@linux.ibm.com> <73b2a139-0664-6dda-13c1-622d51745b30@linux.ibm.com> <804f6ee1-eb62-ea72-648e-1ac9036d0606@linux.ibm.com> <12207532-fe3a-b433-43ef-7e375939467c@linux.ibm.com> <01eb348a-80d2-6338-69e7-73ff693af215@linux.ibm.com> In-Reply-To: <01eb348a-80d2-6338-69e7-73ff693af215@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Di9SVAOBxjtDijigOCiaU9oQnuxF0-2n X-Proofpoint-GUID: XJFnu7nriBTwG4z7Z9ukXVQK98rlNa12 Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-08_01,2023-11-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 mlxlogscore=999 malwarescore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 spamscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311080022 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Gentle ping this series: https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607146.html BR, Kewen >>>>> on 2022/11/24 17:15, Kewen Lin wrote: >>>>>> Hi, >>>>>> >>>>>> Following Segher's suggestion, this patch series is to rework >>>>>> function rs6000_emit_vector_compare for vector float and int >>>>>> in multiple steps, it's based on the previous attempts [1][2]. >>>>>> As mentioned in [1], the need to rework this for float is to >>>>>> make a centralized place for vector float comparison handlings >>>>>> instead of supporting with swapping ops and reversing code etc. >>>>>> dispersedly. It's also for a subsequent patch to handle >>>>>> comparison operators with or without trapping math (PR105480). >>>>>> With the handling on vector float reworked, we can further make >>>>>> the handling on vector int simplified as shown. >>>>>> >>>>>> For Segher's concern about whether this rework causes any >>>>>> assembly change, I constructed two testcases for vector float[3] >>>>>> and int[4] respectively before, it showed the most are fine >>>>>> excepting for the difference on LE and UNGT, it's demonstrated >>>>>> as improvement since it uses GE instead of GT ior EQ. The >>>>>> associated test case in patch 3/9 is a good example. >>>>>> >>>>>> Besides, w/ and w/o the whole patch series, I built the whole >>>>>> SPEC2017 at options -O3 and -Ofast separately, checked the >>>>>> differences on object assembly. The result showed that the >>>>>> most are unchanged, except for: >>>>>> >>>>>> * at -O3, 521.wrf_r has 9 object files and 526.blender_r has >>>>>> 9 object files with differences. >>>>>> >>>>>> * at -Ofast, 521.wrf_r has 12 object files, 526.blender_r has >>>>>> one and 527.cam4_r has 4 object files with differences. >>>>>> >>>>>> By looking into these differences, all significant differences >>>>>> are caused by the known improvement mentined above transforming >>>>>> GT ior EQ to GE, which can also affect unrolling decision due >>>>>> to insn count. Some other trivial differences are branch >>>>>> target offset difference, nop difference for alignment, vsx >>>>>> register number differences etc. >>>>>> >>>>>> I also evaluated the runtime performance for these changed >>>>>> benchmarks, the result is neutral. >>>>>> >>>>>> These patches are bootstrapped and regress-tested >>>>>> incrementally on powerpc64-linux-gnu P7 & P8, and >>>>>> powerpc64le-linux-gnu P9 & P10. >>>>>> >>>>>> Is it ok for trunk? >>>>>> >>>>>> BR, >>>>>> Kewen >>>>>> ----- >>>>>> [1] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606375.html >>>>>> [2] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606376.html >>>>>> [3] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606504.html >>>>>> [4] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606506.html >>>>>> >>>>>> Kewen Lin (9): >>>>>> rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p1 >>>>>> rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p2 >>>>>> rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p3 >>>>>> rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p4 >>>>>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p1 >>>>>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p2 >>>>>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p3 >>>>>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p4 >>>>>> rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p5 >>>>>> >>>>>> gcc/config/rs6000/rs6000.cc | 180 ++++++-------------- >>>>>> gcc/testsuite/gcc.target/powerpc/vcond-fp.c | 25 +++ >>>>>> 2 files changed, 74 insertions(+), 131 deletions(-) >>>>>> create mode 100644 gcc/testsuite/gcc.target/powerpc/vcond-fp.c >>>>>> >