From: Jason Merrill <jason@redhat.com>
To: Patrick Palka <ppalka@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] c++: unifying identical tmpls from current inst [PR108347]
Date: Sat, 16 Sep 2023 16:46:46 -0400 [thread overview]
Message-ID: <ef4a2fbb-0205-3ad9-0351-f1658620ca40@redhat.com> (raw)
In-Reply-To: <20230913175316.4083902-1-ppalka@redhat.com>
On 9/13/23 13:53, Patrick Palka wrote:
> Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look
> OK for trunk?
>
> -- >8 --
>
> Here more_specialized_partial_spec considers the two partial
> specializations to be unordered ultimately because unify for identical
> parm=arg=A<T>::C returns failure due to C being dependent.
>
> This patch fixes this by relaxing unify's early-exit identity test to
> also accept dependent decls; we can't deduce anything further from them
> anyway.
OK.
> In passing this patch removes the CONST_DECL case of unify:
> we should never see the CONST_DECL version of a template parameter here,
> and for other CONST_DECLs (such as enumerators) it seems we can rely on
> them already having been folded to their DECL_INITIAL.
Hmm, I think I'd prefer to add a gcc_unreachable in case we decide to
defer that folding at some point.
Jason
prev parent reply other threads:[~2023-09-16 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 17:53 Patrick Palka
2023-09-16 20:46 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef4a2fbb-0205-3ad9-0351-f1658620ca40@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).