From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id 5C00C385C41C for ; Fri, 23 Jul 2021 17:38:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C00C385C41C Received: by mail-pj1-x1035.google.com with SMTP id mt6so3291375pjb.1 for ; Fri, 23 Jul 2021 10:38:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=3nPMjHfJsCKGyFVbGDz3TIviDoM4tpos6KLX4WPzNII=; b=e8iN96Tm28v9QphufAzpOA2Ob+0z7poGdek57N2OYof+1+r0yflfPAmKWeVnCUhqRZ QoraWMawBmfmczsASUeRTwsPiwJZMgT7cUcppbYWW+6O4dBg1iTgKlmaffqrXjxnByO9 rCR8mTtVowoTVmfzMuVI8yaHH7fTn/8hCc5jIumEnGrAEFepynz8AKSU5rBHgW29Vrom abiXkQIAeNu0iHLR+rCyEfHdQUPzq41tep2GVeGdY6PImPz0m0X51ovPkolzeyZZ40du 4J+VnL7ePkWDY7E5BHEKs3fLDAsAA11xIoFIs12+SX5GKDQXtb7O9v7NMC9bA/Zm/yiX Y2DQ== X-Gm-Message-State: AOAM532bDuzM+Ewvz26nE+UlQlMB+QCSFQcssz/PhwhY7+9EgZkvy1xM FkIYOMWusotym156UkV8IE/u7q+le7bgQg== X-Google-Smtp-Source: ABdhPJzYG/bFgxqaAQwvw3XJubOBouiLMhPSr1IfvSdR6RtoN975bYKoLoo8xFdFCwN/xpeBduPd7w== X-Received: by 2002:a17:90a:e54a:: with SMTP id ei10mr14554732pjb.1.1627061897353; Fri, 23 Jul 2021 10:38:17 -0700 (PDT) Received: from [192.168.1.17] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id 202sm37658751pfy.198.2021.07.23.10.38.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jul 2021 10:38:17 -0700 (PDT) Subject: Re: [PATCH] include: Fix -Wundef warnings in ansidecl.h To: Marek Polacek , GCC Patches References: <20210720220129.198727-1-polacek@redhat.com> From: Jeff Law Message-ID: Date: Fri, 23 Jul 2021 11:38:14 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210720220129.198727-1-polacek@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jul 2021 17:38:20 -0000 On 7/20/2021 4:01 PM, Marek Polacek via Gcc-patches wrote: > This quashes -Wundef warnings in ansidecl.h when compiled in C or C++. > In C, __cpp_constexpr and __cplusplus aren't defined so we evaluate > them to 0; conversely, __STDC_VERSION__ is not defined in C++. > This has caused grief when -Wundef is used with -Werror. > > I've also tested -traditional-cpp. > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > include/ChangeLog: > > * ansidecl.h: Check if __cplusplus is defined before checking > the value of __cpp_constexpr and __cplusplus. Don't check > __STDC_VERSION__ in C++. OK jeff