From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by sourceware.org (Postfix) with ESMTPS id 26BF13858D1E for ; Fri, 10 Nov 2023 20:27:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26BF13858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 26BF13858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699648073; cv=none; b=MKWhBfnMuGDOmSqT08wFEh3gZQzG8jQCJvkiZCp36Ag15gMn4ckez7IyCoUIHQyJB3SCc2fqS7LsT5nAcNqJprgS/ASXhpTuA4Vd80kVV/aDtSLyjA8I8N9zyA36BAB0leReCs6v/VGy+ynEt84Dvv+ilq43+DEq9WiknUiKIjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699648073; c=relaxed/simple; bh=wlZrLevXUaxQWWpBsltY6BcteY0fEfq7rs6nzw4mtJ0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=cdcqdP7PfL/5RGlvvVGLTXxI2n5SManN1077jWx+CaxsNViNPAklSn0jsIWDdSdiJV+HoCs0SedHIxWqsWFw+0Z6yiITTIgXtNrEy5o5bqdZHsPZbABFZnQmfcFnSH8b7tnBXEwOUs+DnG8j/5EMSOzN7284caAVgPCe7A6iugQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-7a66b5f7ea7so84018839f.2 for ; Fri, 10 Nov 2023 12:27:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699648070; x=1700252870; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QQKRpOLFBp6nKyvxMof8sE+7KicnbQdXSlCJX/SX86U=; b=EqTdNqsdy7ASGOrigpAANHbITYs1Sixn+foJxiRPdHxeNQ7JCfRd36qcO5w5qI54NP mUK02l+nYduBT5LHR3kTxnVJqFera9dB8yQC2eY3CaP/W/CUWEB4h5h7xrB6Lx6B6zAG XCubOM6LtHcvqT1uViCv48KDCuDa6YiQvotUo83yewHACeA5ypP8baPAIpa8y7VkXOi+ l9gKkuai9omAfXzeTrgQOwnuKhGSIc+fqaoTNlHv9TURwe2t7Ok45tFIjWAbUqSo1HRL hFfNqLcSJgkeqjYO3zAWrOD9uuOLqcXCln7DFZPGmdqEmQ+uAFakE/MHlS9DKd1n6bNI wXuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699648070; x=1700252870; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QQKRpOLFBp6nKyvxMof8sE+7KicnbQdXSlCJX/SX86U=; b=CPArFxAT37DgqqyFPrzOjcaEP/hm4iYuaK9Qwqd3LtSpFTFoKLGbVrgVSg9VWN3iCj 2lgTF+RenK685X7tJH8WuLaQ6u1nYemhdl7zLH9nE2OVH+U+R8WUz+sC+X2OhxmMdVCY +jxE49mWF5if3Y8wIdCaW31Ptw+WZy/deYAFrTD0LddkJSRtdE41JufesxMA/nsLs64o ygNyFX8y3C33Vux5QotmYc9hQ6TTRfcvYCf8EEIhzFWXDPlyU7QlOC5Snka+0mSRbWOd ufS78O9lzjiW+kkh6w2KF1xQeNvzcJB7OSFMJn6NgmZkEmNtvn6s1p2Mepj4KFVp7cYm LMoA== X-Gm-Message-State: AOJu0YykxOrXZ28mWe9Mfv5G9GVx5K5bCLex1koIrjF63xH+ud7yLvm+ /lVnx2dDRmcCtPa0wEEX3OYCadG079pTuA== X-Google-Smtp-Source: AGHT+IE+ccrB96EJzE7S1kfmLYLygxfAGbIYhBGL/ZJTU16V/ruwD0IoEyJSb/1q82n+H2vvi+ghiA== X-Received: by 2002:a6b:7e0c:0:b0:787:4b5f:b6cf with SMTP id i12-20020a6b7e0c000000b007874b5fb6cfmr483191iom.5.1699648070317; Fri, 10 Nov 2023 12:27:50 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id h22-20020a02c4d6000000b0045bc0378faasm48465jaj.29.2023.11.10.12.27.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Nov 2023 12:27:49 -0800 (PST) Message-ID: Date: Fri, 10 Nov 2023 13:27:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] attribs: Namespace-aware lookup_attribute_spec Content-Language: en-US To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/6/23 05:24, Richard Sandiford wrote: > attribute_ignored_p already used a namespace-aware query > to find the attribute_spec for an existing attribute: > > const attribute_spec *as = lookup_attribute_spec (TREE_PURPOSE (attr)); > > This patch does the same for other callers in the file. > > Tested on aarch64-linux-gnu & x86_64-linux-gnu. OK to install? > > Richard > > > gcc/ > * attribs.cc (comp_type_attributes): Pass the full TREE_PURPOSE > to lookup_attribute_spec, rather than just the name. > (remove_attributes_matching): Likewise. OK jeff