From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id F21E0384AB59 for ; Fri, 26 Apr 2024 08:56:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F21E0384AB59 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F21E0384AB59 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::230 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714121822; cv=none; b=pNbHTNqM0w4ITed8rFqG7/4he4frcClt+eG2zozTiAbCM2bkEgmGo7GPD2aUtNhCpaSzJE8NDXd4IUPr2qZ5h9uX7LIWyEQJir6GeN+yTs8jCD+FnCZNsykNOkmnDXQIe8LmDyJTTfzNOULQExe6sAixqxNSUuCiGCd9mPPv1k0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714121822; c=relaxed/simple; bh=GrzKASmT03qnmr/S2GdAXofoMdqZZmvaIpRJJA2E374=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=bfhXGqZEicN1DGvctzIhB6HQ2rAuhnKfIwonk1kG3filPrXSSRFLN94C4s8nTF0SauUiJRZKrPwxaGWGlKsQ98rrO0knj0AlDjeYcRxzAm8bafsGFQp5QofFk3ZkAhHX+mZ3OjSyk8awqynSKmbDI3d7Gt2kiCUmVcKrqGzZNSY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2db101c11beso20163781fa.0 for ; Fri, 26 Apr 2024 01:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1714121818; x=1714726618; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Tc1lf+dhp1DZZn3KdFUwF3+u/WJ4Y6A4uBgyTiF+BSI=; b=G3O8lyepUbNo4/AngYL3saDkG9nUMIwVO31+m5tyegPtkeWciSvff7Oeq4YYRTt4Dc hD+vsgpX2jAOsyaTLqOwjIHxq1q5XISAc6ru3EuJKDqV5Hb3dGEbIxgV8FlUrRpO8fJQ nGcuvWDK464fTHWTCj5l8F++6geA/6XnvwRyqlpitPtIL4qKLYeSn7N+v1S8oOgn4wFV sT0bUN0zhjhlGgJF95trkuum5mD4jcYqqlCiZqJIAijiZS2r0MK5SeSuJWmqKYql2+6F YJNT/Shh2ANbWcQm7gpoWavYwNSlMqDm+d8hqypk7VL4hu0ytT1wE4xLaeh68XI1bcDQ xGgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714121818; x=1714726618; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Tc1lf+dhp1DZZn3KdFUwF3+u/WJ4Y6A4uBgyTiF+BSI=; b=vOQBmA6yLYUuBibiWKh2VXyIg0CYrlpafkIJZ8lQuqUe0UOtPTJPfj42F/7IS0uYl9 F1A/Uv2qBHNCuINgAsdEScC0/509q52NX0DwFuYhSyKOOh/GeLxuB1doO+K3RN4qYMcO GLOhukHvQEx04UIBolb+naQATJ1STmJLySpGnK3iUh+UXlcIAxQnYpaKLE0uwu3KnVKC MC62bRzmHbXheoucj065gR8JOSNQsXhS+aDUfBVsqoXoTzfWK78oTiXdi/2z9BtU6yzf 2EMgcuf4rAfvKbFNQWU5cPiuFh+xPu/XkHTrzQBQFjRL2Bofo9HlEz1XtfPbYkvNvpRu ugNA== X-Forwarded-Encrypted: i=1; AJvYcCXU9BxJS/+B4+TvQYLcPVuwPRjkPFcn7v4xXvWVoCaA1+xCoCvbuMdZ9tuJ/EySzxTBbQBH6aL+a7t/d6n2o8DmVPBE1BBL+g== X-Gm-Message-State: AOJu0YxRMe51QLkOdNYspEZnvFxfK/tMqlQtmox9S+Vj6Dnj2T11vLbT LAamj7QnLwpXg/AkYs834DizWvKmYxoT3zxvXikD77gWdHRlkIOhqz1VtC/dsDD9TmsPDZKooiw fJ5E= X-Google-Smtp-Source: AGHT+IFtSe+WCo5m3qVrpnxEbGdNZdpN+r90iVxCJZCvckEtw+g6sfWRJ6V4D8TMaGXX8xsXkOeRXQ== X-Received: by 2002:a2e:b527:0:b0:2de:8422:1f14 with SMTP id z7-20020a2eb527000000b002de84221f14mr1012880ljm.19.1714121818235; Fri, 26 Apr 2024 01:56:58 -0700 (PDT) Received: from [192.168.0.118] (hawk-18-b2-v4wan-167765-cust1304.vm26.cable.virginm.net. [82.41.69.25]) by smtp.gmail.com with ESMTPSA id d18-20020a05600c34d200b0041b083e16e2sm8210139wmq.2.2024.04.26.01.56.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Apr 2024 01:56:57 -0700 (PDT) Message-ID: Date: Fri, 26 Apr 2024 09:56:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] amdgcn: Add gfx90c target To: Frederik Harwath , gcc-patches@gcc.gnu.org References: Content-Language: en-GB From: Andrew Stubbs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25/04/2024 19:37, Frederik Harwath wrote: > Hi Andrew, > this patch adds support for gfx90c GCN5 APU integrated graphics devices. > The LLVM AMDGPU documentation (https://llvm.org/docs/AMDGPUUsage.html) > lists those devices as unsupported by rocm-amdhsa. > As we have discussed elsewhere, I have tested the patch on an AMD Ryzen > 5 5500U (also with different xnack settings) that I have and it passes > most libgomp offloading tests. > Although those APUs are very constrainted compared to dGPUs, I think > they might be interesting for learning, experimentation, and testing. > > > Can I commit the patch to the master branch? OK, please go ahead. Thanks for expanding our device support even further! :) Andrew