From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 3487B3858D39 for ; Thu, 23 Nov 2023 09:12:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3487B3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3487B3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700730746; cv=none; b=Nfg0D8ZdaHAbVo6e25haqzCbi2xRsDSF/Rp00b6dFtWN9YnC3jbFW1PRQJlxVHPF6SmN4nR/hXvng64HDtD2n06NiBNWDyIR66FJ8rx8lqt401y2PXEB5QK5SK7+7aNsQHtdZ39X+4M02kLMbsNWewSxhHY799x5uQsWJ+3nSZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700730746; c=relaxed/simple; bh=M89TEZ55wrmtudeIhG8eTV72xOoihB7YhQObwbVkXqs=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=glzbxNK117ojJscSRpvXNxvMN6lpBtcmE3wnMaxemZDe8k7y8fIX1UWd3exo/QCE1aeEXiCJxBiuQyRC0wDKK7r0+a8Lx1LhWP1yw3vOpy4SDyAuaYWmZXGtVzzK8MKVjvZb6vfr2BaGa/UE4xVOucMsT4eJBeQkFfrd6VswtN0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r65kt-000081-Gw for gcc-patches@gcc.gnu.org; Thu, 23 Nov 2023 04:12:22 -0500 Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8Dx_7tiF19lqjs8AA--.60405S3; Thu, 23 Nov 2023 17:12:02 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxiuRgF19lIYhKAA--.34919S3; Thu, 23 Nov 2023 17:12:01 +0800 (CST) Subject: Re: [PATCH v3 1/5] LoongArch: Fix usage of LSX and LASX frint/ftint instructions [PR112578] To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20231120004728.205167-1-xry111@xry111.site> <20231120004728.205167-2-xry111@xry111.site> <2d1c9d59544d15ef7fba07d758431da840cc0bfe.camel@xry111.site> <9ce7e0b2-eeeb-a8c5-2cc7-e9b65b1b2a6b@loongson.cn> From: chenglulu Message-ID: Date: Thu, 23 Nov 2023 17:12:00 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8DxiuRgF19lIYhKAA--.34919S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj9xXoWrKr4Dur4Duw4fuFyUXFWfCrX_yoWfZrXE9r 18Jrn7ursF9Fn7JF4IyFy5Jr92ywsYkrW0gFy0g3Z8G3sFqaykKrWkWF98urn5trWkKrZ7 ur1vqr48ZrsFgosvyTuYvTs0mTUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUbaAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_JrI_Jryl8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE 14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1c AE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMxCIbckI1I0E 14v26r4a6rW5MI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4 CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1x MIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF 4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsG vfC2KfnxnUUI43ZEXa7IU8PCzJUUUUU== Received-SPF: pass client-ip=114.242.206.163; envelope-from=chenglulu@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9,NICE_REPLY_A=-1.672,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_FAIL,SPF_HELO_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2023/11/23 下午5:02, Xi Ruoyao 写道: > On Thu, 2023-11-23 at 16:13 +0800, chenglulu wrote: >> The fix_truncv4sfv4si2 template is indeed called when debugging with >> gdb. >> >> So I think we can use define_expand here. > The problem is cases where we want to combine an rint call with float- > to-int conversion: > > float x[4]; > int y[4]; > > void test() > { > for (int i = 0; i < 4; i++) > y[i] = __builtin_rintf(x[i]); > } > > With define_expand we get "vfrint + vftintrz", but with define_insn we > get a single "vftint". > > Arguably the generic code should try to handle this (PR86609), but it's > "not sure if that's a good idea in general" (comment 1 in the PR) so we > can do this in a target-specific way. > I tried to use Ofast to compile, and found that a vftint was generated, and at.006t.gimple appeared. If O2 was compiled, __builtin_rintf would be generated, but Ofast would generate __builtin_irintf