From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id 161A73851894 for ; Tue, 15 Nov 2022 03:42:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 161A73851894 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1032.google.com with SMTP id d13-20020a17090a3b0d00b00213519dfe4aso12682417pjc.2 for ; Mon, 14 Nov 2022 19:42:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=javMBcUZaYk9y0bv8GCoolOnxdhyy7WpDkwSqMy6Rok=; b=N32oyfR5ADO1tUyG+C6o9rNIRbBmKCWPAPGO7u8TZxd4lKyRWXIXs1oJEcdN1bsJ5l taK084Kn7bx2rvumDPJhT42HFKc0nELwb1FG9Qm7LRx+A21vveFQBf2+r6ePEL4fTVRh xRRKrPfUqJvB+3BV+CBPSujZrmdQq9Etjbz2sAW/RiXAhqbMxKXEXlJpCjEMYvv3NKD5 xsVJ4faN6Nkz7NkeCwdQWY47eL3Vnbn1vLQ/hu01w3KuLVPu0SjGJ2bnwPM/u+6eO0Ay EhKoNTuhK3AbfgiapTUiFhV8WttXwtGXfdXjDTlrzXZ0nZiPkEscm/fzTtWl8pUY+pI0 fqRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=javMBcUZaYk9y0bv8GCoolOnxdhyy7WpDkwSqMy6Rok=; b=XfsB7HPS2ItxO4XvLjpkHcII7ujCkFcGFAQw2FPOlqGGrdGPUyqVDYHmj2tu6+1a5w 8oGO1m+itXFmMvVenmgvRkvTGxyiiBk88ncapSx5HeLFid8dSgQiexwcSBu+0/06+P/A 0umiUOqkbqRxFwGhBXl2q7/gxzZ0sf0Z6ZBk5anRp68a/7UUsH1GEiwrnZQ2SbmSyg2Q olNMrfKRistSHsUps5ScsOtxfzECLxhuUEIDw+V52FG+pVks722voJExMUutxztc+0JC 7Dd+fxyggmHTALgR2N2naXYVUAn/ePxooPmI5GQGRY1pdPUJTAuPAZyw38t/T4eN3S1d bRYA== X-Gm-Message-State: ANoB5pmPR106Z0mUcgoYTkx5Bf3gIHuA0yq7w3iME5oAkK800f5fqD7p BAtCEFmv93VbEh9njo6NKAI= X-Google-Smtp-Source: AA0mqf4zEewPJ0u3w+SfFvJSKygiemMjUjH+lE0vB++He6ir0RzERa9UeKsND9F+G/D7inZFNZz62Q== X-Received: by 2002:a17:902:b081:b0:175:4586:8957 with SMTP id p1-20020a170902b08100b0017545868957mr2087938plr.147.1668483726056; Mon, 14 Nov 2022 19:42:06 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id p22-20020a1709027ed600b00187197c499asm8371440plb.164.2022.11.14.19.42.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 19:42:05 -0800 (PST) Message-ID: Date: Mon, 14 Nov 2022 20:42:03 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] RISC-V: Optimal RVV epilogue logic. Content-Language: en-US To: Kito Cheng , "juzhe.zhong" Cc: jiawei , "kito.cheng" , gcc-patches , palmer , "christoph.muellner" , "philipp.tomsich" , wuwei2016 References: <20221114162918.1563116-1-jiawei@iscas.ac.cn> <4daf8bdf.263a4.18479264c94.Coremail.jiawei@iscas.ac.cn> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/14/22 20:13, Kito Cheng wrote: > I would suggest add a sperated case and scan-assembly-not to demonstrate > this patch. Agreed.  One way to do this would be to have new tests which have the proper dg-directives for testing this issue and #include the original test. So, something like this: /* { dg-do compile } */ /* { dg-options "-march=rv32gcv -mabi=ilp32 -mpreferred-stack-boundary=3 -O3 -fno-schedule-insns -fno-schedule-insns2" } */ #include "spill-1.c" /* Make sure we do not have a useless SP adjustment.  */ /* { dg-final { scan-assembler-not "addi sp, sp, 0" } } */ The key thing to know is that the dg directives are parsed by the framework before preprocessing.  So the dg-directives in spill-1.c would not affect this new test.  That requires us to provide our own, both for how to run the test and what to look for. Jeff